This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
feat!: Move deployment pipeline to CDK #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add implementation guides support via cdk * address comments * fix linting issues
* docs: update docs to support cdk and mark serverless as legacy * add necessary serverless packages back in * address comments
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Bingjiling
approved these changes
Jul 15, 2022
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR adds support for deployment of FHIR-Works on AWS through CDK, and marks serverless deployment as legacy.
This is a breaking change
as deploying with CDK will not automatically update an existing serverless deployment. Serverless is, however, still supported! It will only receive major security patches moving forwards, and any newer features that modify the CloudFormation stack will primarily be geared towards the CDK pipeline.
All of the changes were already approved in separate PRs into this branch, and there are new tests in place to ensure that all the integration tests still pass.
List of PRs:
Checklist:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.