Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

fix: make subscriptions SNS topic name and display name unique for a … #673

Merged

Conversation

Zambonilli
Copy link
Contributor

…stage

Issue #, if available:
Issue 672

Description of changes:
Update the subscriptions SNS topic to be unique per stage.

Checklist:

  • Have you successfully deployed to an AWS account with your changes? (v2.5.1-smart)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Zambonilli Zambonilli requested a review from a team as a code owner August 10, 2022 19:53
@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2022

Codecov Report

Merging #673 (565d1ba) into develop (0883257) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #673   +/-   ##
========================================
  Coverage    95.65%   95.65%           
========================================
  Files            4        4           
  Lines          207      207           
  Branches        30       30           
========================================
  Hits           198      198           
  Misses           9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0883257...565d1ba. Read the comment docs.

Copy link
Contributor

@ssvegaraju ssvegaraju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! This change already exists in the CDK stack, so no need to duplicate to there

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants