Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

fix: update documentation for postman collection and environment #764

Merged
merged 3 commits into from
Jan 10, 2023

Conversation

JayLuo2022
Copy link

@JayLuo2022 JayLuo2022 commented Dec 15, 2022

Issue #, if available:

Description of changes:
change postman/FHIR_SMART.postman_collection.json for deploying SMART on FHIR
Checklist:

  • Have you successfully deployed to an AWS account with your changes?
  • Have you written new tests for your core changes, as applicable?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kcadette kcadette changed the base branch from smart-develop to smart-mainline December 15, 2022 21:39
@kcadette kcadette changed the base branch from smart-mainline to smart-develop December 15, 2022 21:40
Copy link
Contributor

@ssvegaraju ssvegaraju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me, we need to update every request though.

@@ -764,6 +764,11 @@
"auth": {
"type": "oauth2",
"oauth2": [
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make these changes for all requests in this collection.

@github-actions github-actions bot added size/m and removed size/xs labels Dec 16, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #764 (3fd25de) into smart-develop (6429f3b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           smart-develop     #764   +/-   ##
==============================================
  Coverage          92.72%   92.72%           
==============================================
  Files                 13       13           
  Lines                550      550           
  Branches              55       56    +1     
==============================================
  Hits                 510      510           
  Misses                39       39           
  Partials               1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6429f3b...3fd25de. Read the comment docs.

Copy link
Contributor

@ssvegaraju ssvegaraju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@JayLuo2022 JayLuo2022 merged commit 26eb3d5 into smart-develop Jan 10, 2023
@JayLuo2022 JayLuo2022 deleted the update-setup branch January 10, 2023 22:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants