This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
feat: enable hard delete in Elasticsearch #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carvantes
approved these changes
Aug 6, 2021
src/ddbToEs/ddbToEsHelper.test.ts
Outdated
Comment on lines
112
to
117
| const modifyRecord: any = cloneDeep(record); | ||
| modifyRecord.eventName = 'MODIFY'; | ||
| modifyRecord.dynamodb = { | ||
| OldImage: { documentStatus: { S: 'AVAILABLE' } }, | ||
| NewImage: { documentStatus: { S: 'DELETED' } }, | ||
| }; |
There was a problem hiding this comment.
IMO it's simpler to just declare the entire modifyRecord. Cloning and then updating gives little benefit since you need to update almost the entire record anyways.
Suggested change
| const modifyRecord: any = cloneDeep(record); | |
| modifyRecord.eventName = 'MODIFY'; | |
| modifyRecord.dynamodb = { | |
| OldImage: { documentStatus: { S: 'AVAILABLE' } }, | |
| NewImage: { documentStatus: { S: 'DELETED' } }, | |
| }; | |
| const modifyRecord: any = { | |
| eventID: 'some-event-id', | |
| eventName: 'MODIFY', | |
| dynamodb: { | |
| OldImage: { documentStatus: { S: 'AVAILABLE' } }, | |
| NewImage: { documentStatus: { S: 'DELETED' } }, | |
| }, | |
| } |
2 tasks
carvantes
added a commit
that referenced
this pull request
Aug 17, 2021
* feat: Add multi tenancy to S3 binary resource(#87) * feat: tenant isolation for DDB CRUD operations (#86) * feat: update ddbToEs to handle multi-tenant records (#91) * feat: Multi tenancy bulk export (#90) * fix: list bulk export files with tenant prefix (#94) * feat: persistence change for group export (#98) * feat: enable hard delete in Elasticsearch (#100) Co-authored-by: zheyanyu <zheyanyu@amazon.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.