This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
fix: Relax validation rules before a patch can be applied #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to me that body.id check should be removed completely, since none of the patch formats have a body.id field ? |
|
happy to update the pr, if required |
rsmayda
changed the title
|
Hey thanks for cutting us a PR, looks like a good commit! Looks like our Semantic review failed. I updated the title of the PR to follow our standard. When you get the chance could you commit an empty commit to retrigger the check |
rsmayda
changed the title
|
all checks pass now |
rsmayda
approved these changes
Mar 19, 2021
|
This will be added to the next release. Do you have any timelines you are working against with this change? The next release should be near the end of March 2021 |
|
Great. Thanks for accepting my PR. End of March suits us fine. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fhir spec specifies the supported patch content-types at https://www.hl7.org/fhir/http.html#patch
The structure of each patch type is dependent on the content-type.
application/json-patch+jsonpatch type is being rejected due to very strict validation rulesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.