Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Support more robust searching #7

Closed
rsmayda opened this issue Aug 26, 2020 · 8 comments
Closed

Support more robust searching #7

rsmayda opened this issue Aug 26, 2020 · 8 comments
Labels
enhancement New feature or request

Comments

@rsmayda
Copy link
Contributor

rsmayda commented Aug 26, 2020

Currently our search is completed by using 'keyword'. This leaves much to be desired and required from the FHIR spec. Such as:

FHIR spec for context:

A/C:

  • Add functionality
  • Update integration test
@rsmayda rsmayda added the enhancement New feature or request label Aug 26, 2020
@lwarren01
Copy link

We have observed the following issue, which we think falls into the category of more robust search support. When searching using reference parameters it is not performing an exact match of the referenced resource ID. For example, all of the following return the same set of resources:

  • /Patient?organization=19d9bd55-56fc-4d19-850f-2c1ee651aefb
  • /Patient?organization=19d9bd55
  • /Patient?organization=19d9bd55-56fc-4d19-850f-2c1ee651aefb_INVALID_SUFFIX

@luisberga
Copy link

luisberga commented May 17, 2021

Hello!

@lwarren01 this bug is exactly what I need to do in the project that I'm working for.

@rsmayda Do we have a solution forecast for this case? Would there be any way to help you? Due to the progress of the project I'm working on, I have a certain urgency to have this functionality

@rsmayda
Copy link
Contributor Author

rsmayda commented May 24, 2021

@lwarren01 & @luisberga thanks for calling this out we will try to reproduce it this week and get back to you

@carvantes
Copy link
Contributor

@lwarren01 & @luisberga , the exact reference match was brought up on a separate issue: awslabs/fhir-works-on-aws-deployment#329. The fix for it has been released on fhir-works-on-aws-search-es@2.6.1

@Zambonilli
Copy link

We are seeing references with logical identifier not matching results as well.

E.G: POST AuditEvent w/agent.who logical identifier reference

"who": {
    "identifier": "f1d8e233-6c7b-4265-b18f-af286820158c",
    "type": "Patient"
}

@lindenquan
Copy link

It seems search parameters that have "-" are not supported. For example In the Group resource, there is a search parameter called "characteristic-value". And I cannot use this parameter

@medhost-bfindeisen
Copy link

We would like to see the contains string search added:

[base]/Patient?given:contains=eve

Any patients with a name with a given part containing "eve" at any position. This would include patients with the given name "Eve", "Evelyn", and also "Severine".

Of course it would be nice to support all 3 string search scenarios mentioned in 3.1.1.4.8:

  • [base]/Patient?given=eve
    Any patients with a name containing a given part with "eve" at the start of the name. This would include patients with the given name "Eve", "Evelyn".

  • [base]/Patient?given:contains=eve
    Any patients with a name with a given part containing "eve" at any position. This would include patients with the given name "Eve", "Evelyn", and also "Severine".

  • [base]/Patient?given:exact=Eve
    Any patients with a name with a given part that is exactly "Eve". Note: This would not include patients with the given name "eve" or "EVE".

@kcadette
Copy link
Contributor

kcadette commented Apr 3, 2023

FHIR Works on AWS has been moved to maintenance mode. While in maintenance, we will not add any new features to this solution. All security issues should be reported directly to AWS Security at aws-security@amazon.com. If you are new to this solution, we advise you to explore using HealthLake, which is our managed service for building FHIR based transactional and analytics applications. You can get started by contacting your AWS Account team. If you are an existing customer
of FHIR Works on AWS, and have additional questions or need immediate help, please reach out to fwoa-migration-support@amazon.com or contact your AWS Account team.

@kcadette kcadette closed this as completed Apr 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants