Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EKS Launch Template now has multiple mentions of "NODE_TAINT" #11

Closed
syvanen opened this issue Jun 21, 2021 · 2 comments
Closed

EKS Launch Template now has multiple mentions of "NODE_TAINT" #11

syvanen opened this issue Jun 21, 2021 · 2 comments

Comments

@syvanen
Copy link
Contributor

syvanen commented Jun 21, 2021

The awk on the quickinstall.sh line 161 fails because there's multiple lines with NODE_TAINTS=in the launch template now.

By adding -m1 limits the match to first hit making the awk replacement work again. Without this the daemon will fail to add/update the taint in main.py line 206 to fail as there are no taints defined on the node.

Error on logs:

Registering game server
The game server is already registered
The instance is HEALTHY
Updating game server health
Claiming game server
The instance has already been claimed
Changing status to utilized
Traceback (most recent call last):
File "main.py", line 347, in <module>
main()
File "/usr/local/lib/python3.8/site-packages/click/core.py", line 829, in __call__
return self.main(*args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/click/core.py", line 782, in main
rv = self.invoke(ctx)
File "/usr/local/lib/python3.8/site-packages/click/core.py", line 1066, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/local/lib/python3.8/site-packages/click/core.py", line 610, in invoke
return callback(*args, **kwargs)
File "main.py", line 322, in main
initialize_game_server(GameServerGroupName=game_server_group_name, GameServerId=game_server_id, InstanceId=instance_id)
File "main.py", line 207, in initialize_game_server
taints.append(taint)
AttributeError: 'NoneType' object has no attribute 'append'
@jicowan
Copy link
Contributor

jicowan commented Jun 21, 2021

Thanks @syvanen.
cc @trevorrobertsjr

@trevorrobertsjr
Copy link
Contributor

Fixed by #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants