New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate DeepNPTSEstimator
#2496
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostella
added
enhancement
New feature or request
BREAKING
This is a breaking change (one of pr required labels)
labels
Dec 14, 2022
Unsure about the failure, it is only happening on Py38 on ubuntu, works locally (macos) on Python 3.8.13 with torch 1.13.0 (same as in the tests)
|
lostella
force-pushed
the
consolidate-deep-npts
branch
from
January 2, 2023 08:53
bf79c79
to
abe79a7
Compare
lostella
force-pushed
the
consolidate-deep-npts
branch
from
January 17, 2023 09:14
5190433
to
c3ac212
Compare
lostella
added
models
This item concerns models implementations
torch
This concerns the PyTorch side of GluonTS
labels
Jan 20, 2023
jaheba
approved these changes
Jan 20, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
BREAKING
This is a breaking change (one of pr required labels)
enhancement
New feature or request
models
This item concerns models implementations
torch
This concerns the PyTorch side of GluonTS
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
DeepNPTSEstimator.train
arguments to those ofEstimator
andPyTorchLightningEstimator
in particular (move many of its arguments to the constructor)dropout_rate
notOptional
: it's afloat
that can be zeroDeepNPTSEstimator
with similar ones for other estimator classesDeepNPTSMultiStepPredictor
->DeepNPTSMultiStepNetwork
to avoid confusion (since it's not aPredictor
subclass)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup