Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added predict_item to RepresentablePredictor and adapted subclasses. #240

Merged
merged 2 commits into from Aug 13, 2019

Conversation

jaheba
Copy link
Contributor

@jaheba jaheba commented Aug 13, 2019

Addresses #238.

Also added a way to create a MeanPredictor based on an existing Predictor.

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Addresses awslabs#238.

Also added a way to create a MeanPredictor based on an existing Predictor.
@szha
Copy link
Member

szha commented Aug 13, 2019

Job PR-240/1 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-240/1/index.html

@szha
Copy link
Member

szha commented Aug 13, 2019

Job PR-240/2 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-240/2/index.html

@codecov-io
Copy link

Codecov Report

Merging #240 into master will decrease coverage by <.01%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
- Coverage   81.24%   81.24%   -0.01%     
==========================================
  Files         133      133              
  Lines        7429     7432       +3     
==========================================
+ Hits         6036     6038       +2     
- Misses       1393     1394       +1
Impacted Files Coverage Δ
src/gluonts/model/trivial/identity.py 100% <100%> (ø) ⬆️
src/gluonts/model/predictor.py 82.35% <100%> (+0.18%) ⬆️
src/gluonts/model/trivial/constant.py 100% <100%> (ø) ⬆️
src/gluonts/model/trivial/mean.py 94.87% <84.61%> (-2.43%) ⬇️

@lovvge lovvge self-requested a review August 13, 2019 19:09
@jaheba jaheba merged commit b2d7517 into awslabs:master Aug 13, 2019
@jaheba jaheba deleted the mean-predictor2 branch August 13, 2019 19:10
@lostella lostella mentioned this pull request Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants