Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LDS, improve test #65

Merged
merged 1 commit into from Jun 5, 2019
Merged

Fix LDS, improve test #65

merged 1 commit into from Jun 5, 2019

Conversation

lostella
Copy link
Contributor

@lostella lostella commented Jun 4, 2019

Description of changes:

  • The test for LDS was @skip'ed (!!!), now it's enabled
  • By doing that I realized that the sample method of LDS was broken (the case where num_samples=None was not handled correctly), now the shaping problems are fixed
  • The batch_shape/event_shape were also set wrong, now they are fixed and a docstring somewhat related to this has been updated
  • Assertions in the test for LDS where improved/added

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@szha
Copy link
Member

szha commented Jun 4, 2019

Job PR-65/2 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-65/2/index.html

@alexw91
Copy link
Member

alexw91 commented Jun 4, 2019

Codecov Report

Merging #65 into master will increase coverage by 1.26%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
+ Coverage   77.85%   79.11%   +1.26%     
==========================================
  Files         108      108              
  Lines        6199     6200       +1     
==========================================
+ Hits         4826     4905      +79     
+ Misses       1373     1295      -78
Impacted Files Coverage Δ
src/gluonts/distribution/lds.py 88.28% <100%> (+68.28%) ⬆️
src/gluonts/support/util.py 73.68% <0%> (+3.15%) ⬆️

@lostella lostella merged commit 6b86d51 into awslabs:master Jun 5, 2019
@lostella lostella deleted the fix-lds branch June 5, 2019 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants