-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamline "freq", "time_granularity" naming #134
Comments
Given that Pandas use 'freq' (link), this is probably the best option. |
I agree with that. We should make this distinction clear somewhere in the documentation, though, that this is not confused with seasonality frequency. |
I'm currently looking into the shell (essentially integrating with SageMaker) and noticed this too. In SageMaker DeepAR we use |
Consistency is a good argument. But consistency with SageMaker might not necessarily be the right thing in a library. Pandas uses |
I'm fine with either, but at least we should be consistent within GluonTS. Do we have a set of required hyper-parameters? Besides |
Yes, Pandas is much more frequent than Sagemaker, so I also |
Find a naming that is consistent and change it throughout the code for freq/time_granularity.
The text was updated successfully, but these errors were encountered: