Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print warnings or error out when invalid arguments are passed #799

Open
thvasilo opened this issue Apr 15, 2024 · 1 comment
Open

Print warnings or error out when invalid arguments are passed #799

thvasilo opened this issue Apr 15, 2024 · 1 comment
Labels
0.3.1 bug Something isn't working
Milestone

Comments

@thvasilo
Copy link
Contributor

thvasilo commented Apr 15, 2024

With the number of arguments that we parse, it's likely that an arg can be misspelled.

e.g. I ran into the case where I was trying to pass --save-embeds-path instead of save-embed-path which led to my job hanging without an obvious reason.

When unknown arguments are passed to the launch scripts, we should be at least print out a warning, or error out the job (as it will likely lead to something the user did not intend).

More context:

What's happened is that the yaml file had a value for the path, which I tried to override through the CLI.

But the misspelled CLI arg was just ignored and it tried to use the one from the yaml.

@thvasilo thvasilo added bug Something isn't working 0.3 labels Apr 15, 2024
@thvasilo thvasilo added this to the 0.3 release milestone Apr 15, 2024
@classicsong classicsong added 0.3.1 and removed 0.3 labels Jun 19, 2024
@classicsong
Copy link
Contributor

Print out a warning.
We need to support customized args.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.3.1 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants