feat(jsii): Enforce use of peerDependencies #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any direct dependency to another jsii module must be recorded as a
peerDependency as well, guaranteeing a consistent behavior of
dependencies across all possible jsii runtimes.
BREAKING CHANGE: All direct dependencies must be duplicated in
peerDependencies unless they are in bundledDependencies.
Fixes #361
eladb
approved these changes
Apr 2, 2019
packages/jsii/lib/project-info.ts
Outdated
| @@ -38,23 +38,55 @@ export interface ProjectInfo { | |||
| readonly projectReferences?: boolean; | |||
| } | |||
|
|
|||
| export async function loadProjectInfo(projectRoot: string): Promise<ProjectInfo> { | |||
| const pkg = require(path.join(projectRoot, 'package.json')); | |||
| export async function loadProjectInfo(projectRoot: string, fixPeerDependencies: boolean): Promise<ProjectInfo> { | |||
There was a problem hiding this comment.
use keyword arguments for fixPeerDeps
RomainMuller
added
the
pr/breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any direct dependency to another jsii module must be recorded as a
peerDependency as well, guaranteeing a consistent behavior of
dependencies across all possible jsii runtimes.
BREAKING CHANGE: All direct dependencies must be duplicated in
peerDependencies unless they are in bundledDependencies.
Fixes #361
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.