Moved to new setup-envtest script #637
Conversation
|
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: cf3e3e5 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61266a61a518b10007188e32 |
ellistarn
force-pushed
the
kb
branch
3 times, most recently
from
932630b
to
a039c32
Compare
| sudo mkdir -p /usr/local/kubebuilder/bin/ | ||
| sudo mv $TEMP_DIR/kubebuilder_2.3.1_${os}_${arch}/bin/* /usr/local/kubebuilder/bin/ | ||
| echo 'Add kubebuilder to your path `export PATH=$PATH:/usr/local/kubebuilder/bin/`' | ||
| KUBEBUILDER_ASSETS="/usr/local/kubebuilder" |
There was a problem hiding this comment.
Should this be /usr/local/bin/kubebuilder?
There was a problem hiding this comment.
It's unfortunately how the mv command works. I need to clear the previous folder to rename the new folder into place. Otherwise the files get copied into the existing folder.
| KUBEBUILDER_ASSETS="/usr/local/kubebuilder" | ||
| sudo rm -rf $KUBEBUILDER_ASSETS | ||
| sudo mkdir -p $KUBEBUILDER_ASSETS | ||
| sudo mv "$(setup-envtest use -p path 1.19.x)" $KUBEBUILDER_ASSETS/bin |
There was a problem hiding this comment.
If the following is a yes, this should change too
| @@ -116,6 +116,8 @@ github.com/ashanbrown/makezero v0.0.0-20210520155254-b6261585ddde/go.mod h1:oG9D | |||
| github.com/aws/aws-sdk-go v1.23.20/go.mod h1:KmX6BPdI08NWTb3/sm4ZGu5ShLoqVDhKgpiN924inxo= | |||
| github.com/aws/aws-sdk-go v1.25.37/go.mod h1:KmX6BPdI08NWTb3/sm4ZGu5ShLoqVDhKgpiN924inxo= | |||
| github.com/aws/aws-sdk-go v1.36.30/go.mod h1:hcU610XS61/+aQV88ixoOzUoG7v3b31pl2zKMmprdro= | |||
| github.com/benbjohnson/clock v1.1.0 h1:Q92kusRqC1XV2MjkWETPvjJVqKetz1OzxZB7mHJLju8= | |||
There was a problem hiding this comment.
Is there a reason we're adding this in?
There was a problem hiding this comment.
This is just go.sum dependency closure stuff
There was a problem hiding this comment.
Ah do you know which library depends on this one?
There was a problem hiding this comment.
Looks like zap 1.19
go mod graph | grep clock
go.uber.org/zap@v1.19.0 github.com/benbjohnson/clock@v1.1.0
github.com/spf13/viper@v1.7.0 github.com/jonboulle/clockwork@v0.1.0
github.com/spf13/viper@v1.4.0 github.com/jonboulle/clockwork@v0.1.0
go.etcd.io/etcd@v0.0.0-20191023171146-3cf2f69b5738 github.com/jonboulle/clockwork@v0.1.0
github.com/google/certificate-transparency-go@v1.1.1 github.com/jonboulle/clockwork@v0.2.0
github.com/spf13/viper@v1.7.1 github.com/jonboulle/clockwork@v0.1.0
go.etcd.io/etcd@v0.0.0-20200513171258-e048e166ab9c github.com/jonboulle/clockwork@v0.1.0
Issue, if available:
Description of changes:
Upgrading to a newer version of the Kubernetes API Server broke something with Pod Eviction. I spent some cycles trying to get the test fixed (hence all the pdb related code), but wasn't able to sort it out. I think the cleanup changes I made to pdbs are good cleanups anyways, so I left them in.
Will fast follow with reenabling the test soon.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.