Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use instanceProfile from aws cloudprovider constraints api #694

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

bwagner5
Copy link
Contributor

1. Issue, if available:
N/A

2. Description of changes:
InstanceProfile was still hardcoded in the AWS CloudProvider launch template creation code. This change uses the required "InstanceProfile" parameter from the AWS CP API.

3. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Sep 21, 2021

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: b07db8c

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/614a5eb4928d5c00087b5f26

Copy link
Contributor

@ellistarn ellistarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!!

@bwagner5 bwagner5 merged commit b780af4 into aws:main Sep 21, 2021
@bwagner5 bwagner5 deleted the instance-profile-fix branch September 21, 2021 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants