This repository has been archived by the owner on Aug 6, 2018. It is now read-only.
Added proxy settings configuration #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -70,6 +70,49 @@ private void error(String message, Exception e) { | |||
| throw new IllegalStateException(message, e); | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Apologies for not getting back to this earlier. Can you please add documentation on these new settings on the README.md file as well? I will commit this pull request as soon as you update the documentation. We appreciate your contribution and look forward to more in the future.
There was a problem hiding this comment.
Updated README.md with proxy settings info.
ksumit
added a commit
that referenced
this pull request
Oct 11, 2015
Added proxy settings configuration
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #1