Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplified hash #22

Closed
honvl opened this issue Jun 8, 2018 · 1 comment
Closed

simplified hash #22

honvl opened this issue Jun 8, 2018 · 1 comment

Comments

@honvl
Copy link

honvl commented Jun 8, 2018

Hi, thank you for your work. I was able to get this installed in the enterprise, but having to spin up a separate Ubuntu VM for the function was a pain point. It would be nice to have a version with a simplified hash that is static and doesn't include the IP address. This would allow a single curl to be used instead of a bash script, lending support to the Windows task scheduler and simple Unix hosts without jq installed.

@seangreathouse
Copy link
Contributor

Hello,

  • You could remove the dependency on a hashing function in the client by modifying the validate_hash function in the Lambda Python to always return as successful.
  • jq is available for Windows
  • jq is only used as a core part of the client on line 163 where it matches the returned IP. this could be replaced by another method.

I think the best solution may be to use Powershell or Python.
I had plans for a Python client, but a contributor submitted a very nice bash client that I modified vor the v2 version of the project.
There is also an existing Powershell client that was previously contributed and lives in the v1 folder. It should work against the v2 project (even though the Powershell client only supports the v1 feature set) . I did try to make v2 backward compatible with older clients.

Hope this helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants