-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BattlesnakeNotebook initialization fails on S3 bucket name inconsistency #28
Comments
Hey @dangor, I am trying to follow the described steps of your fix. As I am new to AWS I don't quiet understand where to modify the NotebookInstanceExecutionRole's IAM permissions. Could you describe that a little more detailed? Thanks in advance! |
@phossen No worries, I'll try:
I want to note that I've abandoned this project because I found the learning curve for updating the machine learning too high for me for now. Even before that, there will be other challenges you'll run into, e.g. to deal with the APIv0 -> APIv1 migration that Battlesnake now requires. |
Fixed in 7890363 |
After stack creation, the log for
BattlesnakeNotebook/LifecycleConfigOnStart
includes the following line:where
bonhomme-snake
was the value I chose for the parameterSolutionS3BucketName
.Looking in S3, I see that the bucket was named
sagemaker-solutions-bonhomme-snake
.Looking in the CloudFormation template yaml file, I see that the bucket is created with
BucketName: !Sub "sagemaker-solutions-${SolutionS3BucketName}"
:https://github.com/awslabs/sagemaker-battlesnake-ai/blob/master/CloudFormation/deploy-battlesnake-endpoint.yaml#L68
while the sed command doesn't have the same sagemaker-solutions- prefix and only uses the bucket name:
https://github.com/awslabs/sagemaker-battlesnake-ai/blob/master/CloudFormation/deploy-battlesnake-endpoint.yaml#L243-L245
I unstuck myself by manually creating an s3 bucket without the prefix, modifying the NotebookInstanceExecutionRole's IAM permissions to include the new bucket explicitly and objects underneath it, then restarting the notebook instance.
(I did not try updating the sed commands in the script.)
The text was updated successfully, but these errors were encountered: