upgrade to nodejs12.x for all examples and tests #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keetonian
approved these changes
Jan 6, 2020
timoschilling
suggested changes
Jan 7, 2020
| @@ -9,7 +9,7 @@ LambdaEdgeFunctionSample: | |||
| Type: AWS::Serverless::Function | |||
| Properties: | |||
| CodeUri: src/ | |||
| Runtime: nodejs6.10 | |||
| Runtime: nodejs12.x | |||
There was a problem hiding this comment.
Following the lambda@edge requirements guide node12 isn't supported for lambda@edge!
There was a problem hiding this comment.
@timoschilling thank you for checking this. I will update the PR.
ShreyaGangishetty
force-pushed
the
up-nodejs
branch
from
e6a587e
to
8cc084f
Compare
ShreyaGangishetty
force-pushed
the
up-nodejs
branch
from
8cc084f
to
a8a2ba1
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1363 +/- ##
========================================
Coverage 94.42% 94.42%
========================================
Files 78 78
Lines 4555 4555
Branches 912 912
========================================
Hits 4301 4301
Misses 119 119
Partials 135 135Continue to review full report at Codecov.
|
praneetap
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
updated nodejs version in tests and examples to nodejs12.x
Description of how you validated changes:
Checklist:
make prpassesexamples/2016-10-31By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.