Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hover provider #63

Merged
merged 10 commits into from Aug 29, 2022
Merged

Conversation

milesziemer
Copy link
Contributor

Issue #, if available:
#41
Description of changes:
This PR adds the hover action to the LSP, with tests for both IDL 1.0 and 2.0.
Notes:

  • IDL 1.0 tests expect rendered markdown with IDL 2.0 syntax because the model serializer used only generated IDL 2.0 syntax, and there is no IDL 1.0 model serializer. A model serializer is required, as opposed to just rendering the text from the source file, because the rendered markdown may contain more information than is in the text of the source file, and because shapes pulled in as external dependencies would not have accessible source files.
  • Hover support for elision syntax is not included in this PR and is being tracked in Jump to definition and hover support for elided members #62

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@milesziemer milesziemer requested a review from a team as a code owner August 23, 2022 19:33
@milesziemer milesziemer merged commit 37e4745 into smithy-lang:main Aug 29, 2022
@milesziemer milesziemer deleted the add-hover-provider branch August 29, 2022 18:22
@srchase srchase mentioned this pull request Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants