Fix location for elided members #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
approved these changes
Apr 18, 2023
syall
approved these changes
Apr 18, 2023
src/main/java/software/amazon/smithy/lsp/ext/FileCachingCollector.java
Outdated
Show resolved
Hide resolved
…tor.java Co-authored-by: Steven Yuan <s.yuan.all@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in smithy-lang/smithy#1715 which was released with Smithy 1.30.0 fixed the source location of members which are mixed-in, but not re-defined within a structure. This fix resulted in builds for the Language Server failing, as noted in #97.
This PR updates the tests and logic to determine the proper location for mixed-in members that are not re-defined within a structure. Instead of a zero-length location at the start of the structure, members which are not re-defined within the containing structure will instead use the location of the mixed-in member.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.