New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement basic textDocument/documentSymbol #99
Conversation
Could you fix up the checkstyle issues (star import, etc) so we can confirm the rest of CI is successful? |
src/main/java/software/amazon/smithy/lsp/SmithyTextDocumentService.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/smithy/lsp/SmithyTextDocumentService.java
Outdated
Show resolved
Hide resolved
src/test/java/software/amazon/smithy/lsp/SmithyTextDocumentServiceTest.java
Outdated
Show resolved
Hide resolved
done! I can't imagine how you folks can work like this, without an automated rewrite that fixes these issues ;) |
let's see if the file-based way works on Windows... |
Apparently not. Sadly I have no access to a Windows machine so won't be able to play with it. @srchase any hints for resolving this? |
This change fixed the Windows path issue: 0555cfa The issue is that on Windows, documentUri looked like this: |
awesome! let me see if it still works as expected on my machine and I'll pull that in. |
looks alright :) |
Issue #, if available:
Closes #87.
Description of changes:
Implements a basic documentSymbolProvider.
Some limitations of this implementation that may be expanded further in future changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Demo: