Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom extensions support #7

Merged
merged 3 commits into from
Dec 14, 2017
Merged

Add custom extensions support #7

merged 3 commits into from
Dec 14, 2017

Conversation

austinkregel
Copy link
Contributor

@austinkregel austinkregel commented Dec 11, 2017

Changes

  • Adds the ability to add custom file extensions to the search for files with the flags --extentions=php,html or -e php,html

Closes #5

@abdumu
Copy link
Member

abdumu commented Dec 11, 2017

@austinkregel

Could you fix the conflicts and also, filter the given extensions. like using array_map('trim', ..) then array_filter(...). Also it will be great to check if the given extension starts with a dot and remove it.

These are suggestions. You could just fix the conflicts and I would make the rest.

@austinkregel
Copy link
Contributor Author

Like I said I'm at work at the moment, so I won't be able to until tonight, but I sure can :)

@austinkregel
Copy link
Contributor Author

@abdumu I believe that's everything :) Is there anything more I should add or change?

@abdumu abdumu merged commit a563d7a into awssat:master Dec 14, 2017
@abdumu
Copy link
Member

abdumu commented Dec 14, 2017

@austinkregel great, thanks 👍🏼

@austinkregel austinkregel deleted the allow-custom-extensions branch December 14, 2017 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants