E2e #5
Merged
E2e #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awswiftbot
reviewed
Dec 30, 2016
| mutating func write(_ string: String) { | ||
| FileHandle.standardError.write(string.data(using: .utf8)!) | ||
| } | ||
| } | ||
|
|
||
| static func piped(command: String, label: String?) -> (Int, String, String) { |
There was a problem hiding this comment.
Lines should not have trailing whitespace.
awswiftbot
reviewed
Dec 30, 2016
|
|
||
|
|
||
| var redir = Redir() | ||
|
|
||
| if label != nil { | ||
| print("\(label!): ".green + command.bold.green) | ||
| } | ||
|
|
There was a problem hiding this comment.
Lines should not have trailing whitespace.
awswiftbot
reviewed
Dec 30, 2016
| if label != nil { | ||
| print("\(label!): ".green + command.bold.green) | ||
| } | ||
|
|
||
| let exitCode = ShellCommand.command(command: command, stdout: { line in | ||
| print("\(prefix): ".green + line) |
There was a problem hiding this comment.
Lines should not have trailing whitespace.
awswiftbot
reviewed
Dec 31, 2016
| "RUN swift build", | ||
| "WORKDIR .build/debug", | ||
| "RUN mv <packageName> swiftdaEntrypoint", | ||
| "RUN zip /app/lambda.zip swiftdaEntrypoint", |
There was a problem hiding this comment.
Trailing commas in arrays and dictionaries should be avoided/enforced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.