Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies can be added to each separate route (list of dependencies) #60

Merged
merged 12 commits into from Apr 18, 2021
Merged

Dependencies can be added to each separate route (list of dependencies) #60

merged 12 commits into from Apr 18, 2021

Conversation

DorskFR
Copy link
Contributor

@DorskFR DorskFR commented Apr 8, 2021

Hello,

So as discussed in #37

I think this might be how to make a pull request so I give it a try.

If this is not needed or too late, it's fine, I am glad to learn!

closes #59 #37

@vercel
Copy link

vercel bot commented Apr 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/flortz/fastapi-crudrouter/5HWo23gbFCh7ffwwrRGfCaUa1PRa
✅ Preview: https://fastapi-crudrouter-git-fork-dorskfr-dependenciesroutes-flortz.vercel.app

@awtkns
Copy link
Owner

awtkns commented Apr 9, 2021

Hi @DorskFR. This looks great! For here all I guess all we would need to do is update the docs to document this feature.

And maybe write some tests for it (which I can do) 😄

Copy link
Owner

@awtkns awtkns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good to merge once docs are updated.

@DorskFR
Copy link
Contributor Author

DorskFR commented Apr 9, 2021

Hi @awtkns,

Thank you for your reply!
I see you moved the test to check if its a bool or a dependency to the add_api_route.
It's way better indeed, it avoids many repetitions in every router.

Thanks for the opportunity to create this PR.
I will try to study how you wrote the existing tests next.

Edit: not sure if I should do anything here "close or something". Let me know if I should.

@awtkns awtkns linked an issue Apr 11, 2021 that may be closed by this pull request
@awtkns
Copy link
Owner

awtkns commented Apr 18, 2021

@DorskFR Thanks for the PR. The feature is now released with version 0.7.0

@DorskFR DorskFR deleted the dependencies_routes branch December 7, 2021 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Different dependencies per function
2 participants