Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Different dependencies per function #59

Closed
wants to merge 3 commits into from

Conversation

jm-moreau
Copy link
Contributor

Hi Adam, @awtkns

I needed this feature. :) So, I tried to implement it according to the discussion.

Let me know if you have any feedback.

Best,
JM

@vercel
Copy link

vercel bot commented Apr 7, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/flortz/fastapi-crudrouter/7CjjLjPTw9vUBVDhV5vn9AethGb7
✅ Preview: https://fastapi-crudrouter-git-fork-novamera-pass-the-deps-flortz.vercel.app

@awtkns awtkns linked an issue Apr 7, 2021 that may be closed by this pull request
@awtkns awtkns added this to the v0.7 milestone Apr 7, 2021
@awtkns awtkns added the enhancement New feature or request label Apr 7, 2021
@awtkns awtkns changed the title Initial commit [FEAT] Different dependencies per function Apr 7, 2021
@awtkns
Copy link
Owner

awtkns commented Apr 7, 2021

Hey thanks @jm-moreau. Hoping to get a review done for you later today 😄

@jm-moreau
Copy link
Contributor Author

Hey Adam,

Maybe a quick chat would be worthwhile. I am running with fastapi-crudrouter, and had to implement a bunch of things to make it work for my application. But ideally, I could just PR these instead of using and maintaining my own fork. I think a 15 min chat would work out better to bounce ideas than only using github. How does that sound?

@awtkns
Copy link
Owner

awtkns commented Apr 7, 2021

Good idea! @jm-moreau Does right now work? You can send me a chat invite (zoom, teams, discord, etc..) to cadamrun@gmail.com

@awtkns
Copy link
Owner

awtkns commented Apr 11, 2021

Feature moved to PR #60 (Allows for a sequence of dependencies for all CRUDRouter backends).

Still looking at ways to implement the feature we chatted about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Different dependencies per function
2 participants