Table type needs to be visible even if Databases not installed

[agallant]

Great project! I'm happy to report I was able to drop it in along with https://github.com/tiangolo/pydantic-sqlalchemy and it plays nicely with the generated Pydantic models.

That said, I ran into an issue where I had to install Databases in my project to be able to import any code from your package, even though I don't care about the databases connector (just using SQLAlchemy).

fastapi_1  |   File "./main.py", line 6, in <module>
fastapi_1  |     from fastapi_crudrouter import SQLAlchemyCRUDRouter as CRUDRouter
fastapi_1  |   File "/usr/local/lib/python3.8/site-packages/fastapi_crudrouter/__init__.py", line 1, in <module>
fastapi_1  |     from .core import MemoryCRUDRouter, SQLAlchemyCRUDRouter, DatabasesCRUDRouter
fastapi_1  |   File "/usr/local/lib/python3.8/site-packages/fastapi_crudrouter/core/__init__.py", line 5, in <module>
fastapi_1  |     from .databases import DatabasesCRUDRouter
fastapi_1  |   File "/usr/local/lib/python3.8/site-packages/fastapi_crudrouter/core/databases.py", line 16, in <module>
fastapi_1  |     class DatabasesCRUDRouter(CRUDGenerator):
fastapi_1  |   File "/usr/local/lib/python3.8/site-packages/fastapi_crudrouter/core/databases.py", line 18, in DatabasesCRUDRouter
fastapi_1  |     def __init__(self, schema: BaseModel, table: Table, database: Database, *args, **kwargs):
fastapi_1  | NameError: name 'Table' is not defined

Importing SQLAlchemyCRUDRouter ends up looking at the overall package fastapi_crudrouter which ends up looking at that from .core import... etc. etc. until it hits DatabasesCRUDRouter.

Then, the try/except for importing Databases works as expected, but the import for the Table type is also in that block. It's missing, but the rest of the code is still executing, and so it fails as not defined.

This is the simplest/most direct fix, but you could also change the overall from .core import ... model if you want.

Thanks again!

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/flortz/fastapi-crudrouter/b86eudb7c
✅ Preview: https://fastapi-crudrouter-git-fork-agallant-master.flortz.vercel.app

[awtkns]

I can see how that is an issue but I think the proposed solution might also cause problems if SQLAlchemy is not installed.

[awtkns]

This should fix the problems with SQLA and databases

[agallant]

Makes sense, thanks! Added the suggested changes.