Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Default OrderBy for MSSQL #88

Merged
merged 3 commits into from
Aug 21, 2021
Merged

Add Default OrderBy for MSSQL #88

merged 3 commits into from
Aug 21, 2021

Conversation

awtkns
Copy link
Owner

@awtkns awtkns commented Aug 21, 2021

Explicitly states the primary key column as the default column to order by (needed for mssql)

closes #84

@awtkns awtkns added the bug Something isn't working label Aug 21, 2021
@awtkns awtkns self-assigned this Aug 21, 2021
@vercel
Copy link

vercel bot commented Aug 21, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/flortz/fastapi-crudrouter/Ecj84rDpqeMitK2n841RGbKZE9EQ
✅ Preview: https://fastapi-crudrouter-git-84mssqlorderby-flortz.vercel.app

@awtkns awtkns merged commit c37cfab into master Aug 21, 2021
@awtkns awtkns deleted the 84_mssql_order_by branch August 21, 2021 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sqlalchemy.exc.CompileError: MSSQL requires an order_by when using an OFFSET or a non-simple LIMIT clause
1 participant