-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test/document version support, miscellanous #3
Conversation
Fixed CI |
* expand test matrix * add version compatibility table to README * replace set-output with GITHUB_OUTPUT file (pending deprecation) * add tests for pwsh, powershell and cmd on Windows * add cases for uname on Windows: msys* and cygwin* * use Chocolatey to install mingw on Windows * link to libgfortran-5.dll on Windows * link to older version lib paths on Mac * store runner compatibility in CSV file * autodetect runner compatiblity changes * autocreate PR to update README on compat changes
* add table of contents * add sections: outputs, environment variables
Looks like CI may have failed due to restrictions on the automatically provided I'm not sure this will pass in this PR however, as the link above states the maximum access level for forks is |
You can exclude the update step from pull requests, it only makes sense to change the README on a push event. |
Happy to try Intel support here or a separate PR, if you still have that in mind. Could select just C/C++ and Fortran components from the HPC kit to reduce download size — the action could minimally guarantee C/C++/Fortran compilers for either toolchain? |
For the Intel installation the installation procedure provided in spack might be useful: https://github.com/spack/spack/blob/develop/var/spack/repos/builtin/packages/intel-oneapi-compilers/package.py. There seem to be offline installers for the individual components of the toolkits which can be used here. If that PR is ready, I would go ahead and merge it. Support for Intel compilers is best done in a separate PR. |
Ok, will look into Intel/spack in a separate PR. I think this one is ready. A bot update PR is expected on merge, as the CSV I checked in is currently empty. After that it should only update if compatibility changes. |
Hi, thanks for the action. I have a few changes on a fork and wondered if you might be interested in pulling any upstream:
gcc
versionsgcc
version compatibility table to READMEGITHUB_OUTPUT
filemingw
on Windows (considering caching this...)msys*
andcygwin
cases for detected platform (can be returned byuname -s
on Windows)pwsh
(Powershell Core),powershell
(Powershell Desktop) andcmd
on Windowslibgfortran-5.dll
on Windows (avoid missing DLL issues)gcc
lib paths on Mac (avoid missing*.dylib
issues)setup-fortran.sh
Also saw the note on supporting the Intel toolchain — currently accomplishing this with
modflowpy/install-intelfortran-action
, perhaps something could be merged here? It would be nice to have one action for GNU or Intel fortran compilers. (It's now possible to cache files and update environment variables in composite actions.)