-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completely revamp how we layout pages #18
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidknezic
force-pushed
the
feature/revamp-layout
branch
from
October 21, 2016 08:28
87d3915
to
e4dabdd
Compare
davidknezic
changed the title
WIP: Completely revamp how we layout pages
Completely revamp how we layout pages
Oct 24, 2016
davidknezic
force-pushed
the
feature/revamp-layout
branch
from
October 24, 2016 16:07
6b58cb4
to
a35f3f7
Compare
FKSI
approved these changes
Oct 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to simplify how we build web apps, I'm proposing this complete revamp of our page layout.
It's aim is:
.site
,.site__page
and.site__mobile
structure on every sitefixed
positioned elements, like sticky headersNow an image that really made you read this pr, but won't help you because even I don't understand it anymore:
So far these are the changes:
drawer
blockpersistent-{breakpoint}-left
and-right
modifiers, if it should always be opentogglable-{breakpoint}-left
and-right
modifiers, if it should be togglable by adding thein
classtogglable-{breakpoint}-top
modifier, if it should toggle from above by adding thein
classmask
blockoverflow-{breakpoint}-hidden
utilspush-{breakpoint}-left
and-right
utils (should be renamed)The idea is the following:
You have all the classes available so you can define all possible layouts in your markup. You can use different layouts per viewport.
Things pending:
Document all Sass utilities(Define docs structure, add missing docs #22)Write a guide on how to layout web apps(Define docs structure, add missing docs #22)drawer
the right name for that thing that can either slide into your viewport or be there persistently?push-{breakpoint}-{direction}
utils are here to add padding to all the content to make room for a persistentdrawer
. Ispush
the right name for that?