Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely revamp how we layout pages #18

Merged
merged 19 commits into from
Oct 25, 2016
Merged

Conversation

davidknezic
Copy link
Contributor

@davidknezic davidknezic commented Oct 20, 2016

In order to simplify how we build web apps, I'm proposing this complete revamp of our page layout.

It's aim is:

  • Don't force the .site, .site__page and .site__mobile structure on every site
  • Let developers drop content into body directly
  • Remove every overhead from very simple sites
  • Make it easier to use fixed positioned elements, like sticky headers

Now an image that really made you read this pr, but won't help you because even I don't understand it anymore:

screen shot 2016-10-20 at 22 20 44

So far these are the changes:

  • New drawer block
    • persistent-{breakpoint}-left and -right modifiers, if it should always be open
    • togglable-{breakpoint}-left and -right modifiers, if it should be togglable by adding the in class
    • togglable-{breakpoint}-top modifier, if it should toggle from above by adding the in class
  • New mask block
  • Copied the super helpful breakpoint mixins from Bootstrap v4
  • New overflow-{breakpoint}-hidden utils
  • New push-{breakpoint}-left and -right utils (should be renamed)

The idea is the following:

You have all the classes available so you can define all possible layouts in your markup. You can use different layouts per viewport.

Things pending:

  • Write a jQuery plugin for the mobile behavior
  • Document all Sass utilities (Define docs structure, add missing docs #22)
  • Write a guide on how to layout web apps (Define docs structure, add missing docs #22)
  • Is drawer the right name for that thing that can either slide into your viewport or be there persistently?
  • The push-{breakpoint}-{direction} utils are here to add padding to all the content to make room for a persistent drawer. Is push the right name for that?

@davidknezic davidknezic mentioned this pull request Oct 21, 2016
6 tasks
@davidknezic davidknezic changed the title WIP: Completely revamp how we layout pages Completely revamp how we layout pages Oct 24, 2016
@davidknezic
Copy link
Contributor Author

@davidknezic
Copy link
Contributor Author

Going to merge this in order to start with the cleanup of the docs. After that, there will be a pr documenting and explaining the modular header (#12) and the new revamped layout. Tracking documentation in #22.

@davidknezic davidknezic merged commit 4070c5e into master Oct 25, 2016
@davidknezic davidknezic deleted the feature/revamp-layout branch October 25, 2016 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants