Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/phantom screenshots #46

Merged
merged 54 commits into from
Nov 11, 2016
Merged

Feature/phantom screenshots #46

merged 54 commits into from
Nov 11, 2016

Conversation

elessar-ch
Copy link
Contributor

This PR includes everything needed to create and compare screenshots during the build.
The process is executed in a secondary rancher-container.

@elessar-ch
Add first draft of making screenshots
5e2e33c
@elessar-ch
Make sure all pages are rendered?
5f73647
@elessar-ch
Load stylesheet for demos in the head
f437033
@elessar-ch
Do screenshots in multiple viewports
ea43563
@elessar-ch
Draft changes for comparing screenshots
b84afd2
@elessar-ch
Refactor the screenshot scripts
28b959c
@elessar-ch
Output diff image after comparing screenshots
02ccac7
@elessar-ch
Add package.json and Dockerize the whole thing
d4da9eb
@elessar-ch
Save screenshots in specified path
6c24676
@elessar-ch
Compare all the screenshots recorded
e1c0887
@elessar-ch
Add fonts to phantomjs image.
26f864d
@elessar-ch
Add diff directory in docker image
9aee73d
@elessar-ch
Add font-test demo page
708192d
@elessar-ch
Fix test definitions
71f73e4
@elessar-ch
Add test for fonts
92fcbcc
@elessar-ch
Fix expected pages
0ec7903
@elessar-ch
Fix expected file for font-test
9888c34
@elessar-ch
Try adding docker image for tests to jenkinsfile
7edd309
@elessar-ch
Fix typo in path in jenkinsfile
7978100
@elessar-ch
Start the test container along the web container
a13678c
@elessar-ch
Add link to web container
bca90fe
@elessar-ch
Make run-tests executable
b73355e
@elessar-ch
Start test service only once
cd156f7
@elessar-ch
Add test image parameter to rancher compose commands
2964010
@elessar-ch
Change screenshot paths
010f56b
@elessar-ch
Add results page
0927d11
@elessar-ch
Add handlebars dependency for results page
971b762
@elessar-ch
Integrate test results into toolkit
458aa13
@elessar-ch
Name link in test container
1a56d2c
@elessar-ch
Reuse volume from the toolkit container for test
cadfae0
@elessar-ch
Copy link
Contributor Author

Currently working on making this thing a bit cooler :P

@elessar-ch
Copy link
Contributor Author

elessar-ch commented Nov 9, 2016 •
edited

Allright, I think we're close to merging now.

  • Moved to ES6
  • Doing the snapshots now in node too (with PhantomJS Node bridge)
  • Improved result page with some colors (don't get too excited)
  • Removed PT Serif
  • Fixed typos in readme :P and extended it a bit
  • All branches will have their branch-name as the BASE_URL with most special characters replaced by a dash - when deployed on rancher
  • Master branch is the exception and will still be hosted on /toolkit BASE_URL

davidknezic
davidknezic suggested changes Nov 11, 2016
View reviewed changes
Copy link
Contributor

@davidknezic davidknezic left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just three things

  • docker-compose.yml and font-test.hbs still have no newlines

    screen shot 2016-11-11 at 11 30 01

  • You can remove three more fonts, because we don't use italics anywhere (and hopefully never will)

    • SourceSansPro-BoldIt.ttf
    • SourceSansPro-It.ttf
    • SourceSansPro-SemiboldIt.ttf

  • And I'd prefer if the tests/readme.md filename was capsed README.md.

Everything else, amazing! 🎉

@elessar-ch
Copy link
Contributor Author

@davidknezic fixed

davidknezic
davidknezic approved these changes Nov 11, 2016
View reviewed changes
Copy link
Contributor

@davidknezic davidknezic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@davidknezic davidknezic merged commit 66180d1 into master Nov 11, 2016
@davidknezic davidknezic deleted the feature/phantom-screenshots branch November 11, 2016 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidknezic davidknezic davidknezic approved these changes

Assignees

@davidknezic davidknezic

@elessar-ch elessar-ch

Labels
None yet
Projects
AXA Web Toolkit
Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elessar-ch @davidknezic