Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some docs about alerts #76

Merged
merged 3 commits into from
Nov 25, 2016
Merged

Add some docs about alerts #76

merged 3 commits into from
Nov 25, 2016

Conversation

elessar-ch
Copy link
Contributor

No description provided.

{{#*inline "content"}}
<h1 class="h2">{{title}}</h1>
<p class="lead">
Our alerts are 100% bootstrap based on Bootstrap.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum 🤔

@elessar-ch
Copy link
Contributor Author

Thx @FKSI for pointing out the typo

</div>
<div class="alert alert-danger" role="alert">
<strong>Danger!</strong> Are you sure you want to release the raptors?
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if this could also be split up into multiple snippets, so it's easier to figure out which example belongs to what code snippet. Thoughts @elessar-ch @FKSI?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If split, I'd see

<div class="alert alert-success" role="alert">
  <strong>Well done!</strong> You successfully read this important alert message.
</div>
<div class="alert alert-info" role="alert">
  <strong>Heads up!</strong> This alert needs your attention, but it's not super important.
</div>
<div class="alert alert-danger" role="alert">
  <strong>Danger!</strong> Are you sure you want to release the raptors?
</div>

And

<div class="alert alert-warning alert-dismissible" role="alert">
  <strong>Warning!</strong> Pushing the x on the right will remove this alert. For EVER!
  <button type="button" class="close" data-dismiss="alert" aria-label="Close">
    <span aria-hidden="true">&times;</span>
  </button>
</div>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, it would be the different appearances first and then how to make it dismissable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that tiny little bit of code should be clear enough for anybody.

image

@davidknezic davidknezic merged commit c919300 into master Nov 25, 2016
@davidknezic davidknezic deleted the feature/alerts-docs branch November 25, 2016 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants