Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bautajs-core): update tap behaviour to make it consistent #139

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

Xavier-Redondo
Copy link
Contributor

Pull Request Template

PR Checklist

  • I have run npm test locally and all tests are passing.
  • I have added/updated tests for any new behavior.
  • I have added/updated documentation for any new behavior.
  • If this is a significant change, an issue has already been created where the problem / solution was discussed: [N/A, or add link to issue here]

PR Description

This implements issue #138.

Basically implements tap in a consistent manner following the expected definition of the function tap function common in other languages/frameworks.

The detail of this definitioin is explained in the documentation of the pr itself, but a very brief defintion is this:

Given a set of step functions inside tap, the end result of tap is:

- either an exception if there was an exception while processing them
- the value received by the first step function inside tap decorator as its result

The end purpose of tap is allow side effects without losing the value used in the previous step function.

@Xavier-Redondo Xavier-Redondo requested a review from a team as a code owner February 27, 2024 08:59
Copy link

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@Xavier-Redondo Xavier-Redondo changed the title Feat/tap should work consistently feat(bautajs-core): update tap behaviour to make it consistent Feb 27, 2024
@Xavier-Redondo Xavier-Redondo added enhancement New feature or request bautajs-core labels Feb 27, 2024
Copy link
Contributor

@franher franher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@franher franher merged commit 5e318af into main Apr 4, 2024
12 of 13 checks passed
@franher franher deleted the feat/tap-should-work-consistently branch April 4, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bautajs-core enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants