Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate codebase to Typescript #94

Closed
vvscode opened this issue Oct 15, 2018 · 5 comments
Closed

Migrate codebase to Typescript #94

vvscode opened this issue Oct 15, 2018 · 5 comments

Comments

@vvscode
Copy link
Contributor

vvscode commented Oct 15, 2018

What about migrating codebase to TS? Not the whole codebase in one time, but at least add support for tsc to make at possible add types further.

@jesus-seijas-sp
Copy link
Contributor

Well, currently is a yes and a no at the same time. I will try to explain :)
We are doing a backend in nest.js, and the frontend should be in react taking what is already done in articulate: https://github.com/samtecspg/articulate

Our code is started, of course in typescript, here https://github.com/axa-group/dost

I think that the main focus right now should be to have an MVP of the frontend of articulate, agains the backend done in nest.js (already have the API and using NLP.js). When this MVP is finished, we will continue with the focus in this codebase.

@vvscode vvscode closed this as completed Oct 15, 2018
@shadow1349
Copy link

I really like this library, but it's a pain to use in TypeScript. @jesus-seijas-sp you guys wouldn't have to rewrite the whole thing you guys could publish a library in the DefinitelyTyped repo so you could have an @types/nlp.js package. It would be minimal effort.

@miloshavlicek
Copy link

@jesus-seijas-sp Is there any plan to support Typescript types? E.g. by creating DefinitelyTyped repo @types/node-nlp?

@luddilo
Copy link

luddilo commented Aug 11, 2020

+1, this would be very useful

@msolefonte
Copy link

Push for the @types/node-nlp repository. It would be a really good addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants