Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--bandwidth-log segmentation fault when numjobs even multiple of 8 #1534

Closed
1 task done
horshack-dpreview opened this issue Mar 3, 2023 · 0 comments
Closed
1 task done

Comments

@horshack-dpreview
Copy link
Contributor

Please acknowledge the following before creating a ticket

Description of the bug:
When the aggregate bandwidth log is enabled (--bandwidth-log), a segmentation fault will occur if numjobs is an even multiple of 8.

Environment: Ubuntu 22.04.2 LTS

fio version: 3.33 (tip of master)

Reproduction steps
Create 1GB ramdisk: sudo modprobe brd rd_size=1024000 rd_nr=1
Then run: sudo fio -name=test --filename=/dev/ram0 -bs=4K -size=1GB -rw=write --numjobs=8 --bandwidth-log

horshack-dpreview added a commit to horshack-dpreview/fio that referenced this issue Mar 3, 2023
Segmentation fault occurs when aggregate bandwidth logging is enabled
(--bandwidth-log) and numjobs is an even multiple of 8. Fault occurs
because logic is using the terminating value of struct thread_data *td
from the most recent for_each_td(). This bug was caught by the
refactoring of for_each_td().

Link: axboe#1534

Signed-off-by: Adam Horshack (horshack@live.com)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant