Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFS engine via libnfs #1216

Merged
merged 6 commits into from
May 18, 2021
Merged

NFS engine via libnfs #1216

merged 6 commits into from
May 18, 2021

Conversation

tarasglek
Copy link
Contributor

For scale-out storage, driving load through the kernel requires a lot more resources than driving load from user-space, thus libnfs binding came into being.

For now this is just block IO. Eventually I'd like to let fio drive metadata operations too.

We love fio at Pure Storage. Between various kernel modes, S3 and libnfs fio gives us a nice way to validate storage performance.

@sitsofe sitsofe self-requested a review April 13, 2021 18:18
sitsofe
sitsofe requested changes Apr 16, 2021
View reviewed changes
Copy link
Collaborator

@sitsofe sitsofe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly style but I think there might be some local changes that need to be removed...

configure Outdated Show resolved Hide resolved
configure Outdated Show resolved Hide resolved
engines/nfs.c Outdated Show resolved Hide resolved
engines/nfs.c Outdated Show resolved Hide resolved
engines/nfs.c Show resolved Hide resolved
examples/nfs.fio Outdated Show resolved Hide resolved
HOWTO Show resolved Hide resolved
engines/nfs.c Outdated Show resolved Hide resolved
engines/nfs.c Outdated Show resolved Hide resolved
HOWTO Show resolved Hide resolved
@tarasglek tarasglek requested a review from sitsofe May 5, 2021 16:12
@tarasglek
Copy link
Contributor Author

ping @sitsofe or @axboe, I believe I addressed all the concerns raised above.

@axboe
Copy link
Owner

axboe commented May 18, 2021

Pulled, thanks.

@axboe axboe merged commit b54e0d8 into axboe:master May 18, 2021
@VVD
Copy link

VVD commented Apr 16, 2022

Version 3.30:

./configure --enable-nfs
Bad option --enable-nfs

./configure --enable-libnfs
Bad option --enable-libnfs

But ./configure --disable-nfs work without errors.

@axboe
Copy link
Owner

axboe commented Apr 16, 2022

@tarasglek Does look like the configure additions are fairly random and broken, care to fix it up?

@tarasglek
Copy link
Contributor Author

Happy to fix it, but wont have time for 2 weeks.

@VVD
Copy link

VVD commented Jul 5, 2022

ping

@axboe
Copy link
Owner

axboe commented Jul 5, 2022

@tarasglek please get this sorted out, it's been months now. If not, I'm going to revert the series.

axboe added a commit that referenced this pull request Jul 5, 2022
@axboe
configure: revert NFS configure change
1eb5ca7 
It's broken and nobody seems to be stepping up to fix it, revert the
known problematic change.

Fixes: 165b8a7 ("NFS configure fixes")
Link: #1216
Signed-off-by: Jens Axboe <axboe@kernel.dk>
@axboe
Copy link
Owner

axboe commented Jul 5, 2022

@VVD does it work in current -git now?

@VVD
Copy link

VVD commented Aug 13, 2022

@axboe, in 3.31 --enable-libnfs and --disable-libnfs work as expected, thanks!

P.S. Last several months github doesn't send me emails if I subscribed on issues…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sitsofe sitsofe Awaiting requested review from sitsofe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tarasglek @axboe @VVD @sitsofe