Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing io_uring_submit_and_wait_timeout() function in API #440

Closed
lano1106 opened this issue Sep 23, 2021 · 8 comments
Closed

Missing io_uring_submit_and_wait_timeout() function in API #440

lano1106 opened this issue Sep 23, 2021 · 8 comments

Comments

@lano1106
Copy link

before commit 0ea4ccd ("src/queue: don't flush SQ ring for new wait interface"),
io_uring_wait_cqes() was serving the purpose of submit sqe and wait for cqe up to a certain timeout value.

Since the commit, a new function is needed to fill this gap.

@isilence
Copy link
Collaborator

Related: #347

@axboe
Copy link
Owner

axboe commented Sep 24, 2021

@lano1106 You were going to add this, correct? If not, I can do it.

@lano1106
Copy link
Author

yes I can do it. You have more important things to take care of...

@axboe
Copy link
Owner

axboe commented Sep 24, 2021

You have more important things to take care of...

Feels like I need to take another look at the signal vs coredump issues...

@lano1106
Copy link
Author

yes that but imho, this is not that urgent. It seems that I am the only one affected by the coredump issue and the fix is baked in my build (and my app isn't coredumping anymore!)...

I had in mind all the emails that I am seeing flying on the list plus the tasks required for the current dev cycle...

@axboe
Copy link
Owner

axboe commented Sep 24, 2021

One thing is for sure, we won't run out of things to work on any time soon...

@axboe
Copy link
Owner

axboe commented Oct 2, 2021

@lano1106 Did you make any progress on this one?

@lano1106
Copy link
Author

lano1106 commented Oct 4, 2021

I am done. I'm preparing the patch

@axboe axboe closed this as completed in a060c8e Oct 4, 2021
ammarfaizi2 pushed a commit to ammarfaizi2/liburing that referenced this issue Oct 6, 2021
before commit 0ea4ccd ("src/queue: don't flush SQ ring for new wait interface"),
io_uring_wait_cqes() was serving the purpose of submit sqe and wait for cqe up to a certain timeout value.

Since the commit, a new function is needed to fill this gap.

Fixes: axboe#440
Signed-off-by: Olivier Langlois <olivier@trillion01.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants