Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build broken on systems without linux/time_types.h #708

Closed
metze-samba opened this issue Oct 24, 2022 · 0 comments · Fixed by #709 or #761
Closed

build broken on systems without linux/time_types.h #708

metze-samba opened this issue Oct 24, 2022 · 0 comments · Fixed by #709 or #761

Comments

@metze-samba
Copy link
Contributor

Commit 00dcfc1 ("io_uring: uapi: Sync with the kernel") broke
the build on systems without linux/time_types.h.

configure has code to cope a missing time_types.h, but the kernel's uapi header
forces it currently...

@axboe axboe closed this as completed in 4189c79 Oct 24, 2022
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Nov 15, 2022
include/uapi/linux/io_uring.h is synced 1:1 into
liburing:src/include/liburing/io_uring.h.

liburing has a configure check to detect the need for
linux/time_types.h.

Fixes: 78a861b ("io_uring: add sync cancelation API through io_uring_register()")
Link: axboe/liburing#708
Link: axboe/liburing#709
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-fork that referenced this issue Nov 15, 2022
include/uapi/linux/io_uring.h is synced 1:1 into
liburing:src/include/liburing/io_uring.h.

liburing has a configure check to detect the need for
linux/time_types.h.

Fixes: 78a861b ("io_uring: add sync cancelation API through io_uring_register()")
Link: axboe/liburing#708
Link: axboe/liburing#709
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Link: https://lore.kernel.org/r/20221115212614.1308132-2-ammar.faizi@intel.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-fork that referenced this issue Dec 27, 2022
include/uapi/linux/io_uring.h is synced 1:1 into
liburing:src/include/liburing/io_uring.h.

liburing has a configure check to detect the need for
linux/time_types.h. It can opt-out by defining
UAPI_LINUX_IO_URING_H_SKIP_LINUX_TIME_TYPES_H

Fixes: 78a861b ("io_uring: add sync cancelation API through io_uring_register()")
Link: axboe/liburing#708
Link: axboe/liburing#709
Link: https://lore.kernel.org/io-uring/20221115212614.1308132-1-ammar.faizi@intel.com/T/#m9f5dd571cd4f6a5dee84452dbbca3b92ba7a4091
CC: Jens Axboe <axboe@kernel.dk>
Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Link: https://lore.kernel.org/r/7071a0a1d751221538b20b63f9160094fc7e06f4.1668630247.git.metze@samba.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
metze-samba added a commit to metze-samba/liburing that referenced this issue Dec 28, 2022
…es.h

This is similar to commit 4189c79,
"uapi: Sync with the kernel in order to build systems without linux/time_types.h"

Now we opt-in and define UAPI_LINUX_IO_URING_H_SKIP_LINUX_TIME_TYPES_H
if there's no linux/time_types.h in the system and we provide
replacements for the required types.

Fixes: axboe#708
Fixes: 4189c79 ("uapi: Sync with the kernel in order to build systems without linux/time_types.h")
Link: https://lore.kernel.org/io-uring/167215158915.44294.15174860895720844240.b4-ty@kernel.dk/T/#t
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant