New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for skipping files in kernel patch. This will add tests / documentation for said patch. #284
Conversation
This commit add test_skip which tests that IORING_REGISTER_FILES_UPDATE will succeed with fds set as IORING_REGISTER_FILES_SKIP and that the underlying registered file is unaffected. Signed-off-by: Noah Goldstein <goldstein.w.n@gmail.com>
Add documentation for IORING_REGISTER_FILES_SKIP feature in IORING_REGISTER_FILES_UPDATE. Signed-off-by: Noah Goldstein <goldstein.w.n@gmail.com>
The mystery for me is where the kernel patch itself... |
It was posted. Seems like lore/vger has some issues these days, so slow... |
its not on lore yet but should be visible through email ccd to:
I'll add you directly as a cc in the future (if you want. now that I think about you might not want to clutter your email). For now forwarded it to you. |
Delivered after 9630 seconds, nice... Looks like a good occasion to finally add myself into /MAINTEINERS. |
I'll add you to maintainers. But yes, it's really annoying why it keeps adding Al when you just use the maintainers script. Not sure there's a way to solve that without moving it into kernel/io_uring/ (which would be more appropriate than fs/io_uring/). |
Actually just send a patch for that yourself :-) |
|
Yeah, it'd work for that entry. Arguably io_uring should just be moved, but let's just work around it instead. |
Since I'm not committing directly, reviewer (aka R:) makes more sense, don't you think? |
Sure, that works for me. It means you'll get CC'ed on patches, which would eliminate annoying delays like today. |
Agree, bad for history and doesn't matter anyway. |
git would track the history fine, but it'd be a pain for backports etc. No point in having such a flag day, location doesn't really matter if we can fix this maintainers annoyance. |
This is to add testing / documentation for patch:
0001-io_uring-Add-skip-option-for-__io_sqe_files_update.patch
if it is applied.Should not be accepted unless the patch is as well.