Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for skipping files in kernel patch. This will add tests / documentation for said patch. #284

Merged
merged 2 commits into from Jan 26, 2021

Conversation

goldsteinn
Copy link
Contributor

This is to add testing / documentation for patch: 0001-io_uring-Add-skip-option-for-__io_sqe_files_update.patch if it is applied.

Should not be accepted unless the patch is as well.

This commit add test_skip which tests that
IORING_REGISTER_FILES_UPDATE will succeed with fds set as
IORING_REGISTER_FILES_SKIP and that the underlying registered file is
unaffected.

Signed-off-by: Noah Goldstein <goldstein.w.n@gmail.com>
Add documentation for IORING_REGISTER_FILES_SKIP feature in
IORING_REGISTER_FILES_UPDATE.

Signed-off-by: Noah Goldstein <goldstein.w.n@gmail.com>
@axboe axboe merged commit 5bbf215 into axboe:master Jan 26, 2021
@isilence
Copy link
Collaborator

The mystery for me is where the kernel patch itself...

@axboe
Copy link
Owner

axboe commented Jan 26, 2021

It was posted. Seems like lore/vger has some issues these days, so slow...

@goldsteinn
Copy link
Contributor Author

goldsteinn commented Jan 26, 2021

The mystery for me is where the kernel patch itself...

its not on lore yet but should be visible through email ccd to:

axboe@kernel.dk,
viro@zeniv.linux.org.uk,
io-uring@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
goldstein.w.n@gmail.com

I'll add you directly as a cc in the future (if you want. now that I think about you might not want to clutter your email).

For now forwarded it to you.

@isilence
Copy link
Collaborator

Delivered after 9630 seconds, nice...

Looks like a good occasion to finally add myself into /MAINTEINERS.
How about removing io_uring from under Al/fsdevel?

@axboe
Copy link
Owner

axboe commented Jan 27, 2021

I'll add you to maintainers. But yes, it's really annoying why it keeps adding Al when you just use the maintainers script. Not sure there's a way to solve that without moving it into kernel/io_uring/ (which would be more appropriate than fs/io_uring/).

@axboe
Copy link
Owner

axboe commented Jan 27, 2021

I'll add you to maintainers

Actually just send a patch for that yourself :-)

@isilence
Copy link
Collaborator

isilence commented Jan 27, 2021

X: exclude from FILESYSTEMS, maybe? It works, but kind of...

@axboe
Copy link
Owner

axboe commented Jan 27, 2021

Yeah, it'd work for that entry. Arguably io_uring should just be moved, but let's just work around it instead.

@isilence
Copy link
Collaborator

I'll add you to maintainers. But yes, it's really annoying why it keeps adding Al when you just use the maintainers script. Not sure there's a way to solve that without moving it into kernel/io_uring/ (which would be more appropriate than fs/io_uring/).

Since I'm not committing directly, reviewer (aka R:) makes more sense, don't you think?

@axboe
Copy link
Owner

axboe commented Jan 27, 2021

Sure, that works for me. It means you'll get CC'ed on patches, which would eliminate annoying delays like today.

@isilence
Copy link
Collaborator

isilence commented Jan 27, 2021

Yeah, it'd work for that entry. Arguably io_uring should just be moved, but let's just work around it instead.

Agree, bad for history and doesn't matter anyway.

@axboe
Copy link
Owner

axboe commented Jan 27, 2021

git would track the history fine, but it'd be a pain for backports etc. No point in having such a flag day, location doesn't really matter if we can fix this maintainers annoyance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants