-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update io_uring-udp.c #815
Conversation
examples/io_uring-udp.c
Outdated
@@ -275,7 +275,7 @@ static int process_cqe_recv(struct ctx *ctx, struct io_uring_cqe *cqe, | |||
const char *name; | |||
struct sockaddr_in *addr = io_uring_recvmsg_name(o); | |||
|
|||
name = inet_ntop(ctx->af, addr, buff, sizeof(buff)); | |||
name = inet_ntop(ctx->af, &(addr->sin_addr), buff, sizeof(buff)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just make this:
name = inet_ntop(ctx->af, &addr->sin_addr, buff, sizeof(buff));
as there's no need for the parenthesis in there.
Fix looks good (with cosmetic adjustment suggested), but your commit message should be better. First of all, the first line should be a title for the commit. "Update foo.c" doesn't mean anything, what is being changed here? And then the body should have an explanation of why the change is necessary. Finally, a Signed-off-by line is required with your identity (name) and email as well. See the other commits in the repo for an example of what a commit message should look like. Here's one from Pavel: https://git.kernel.dk/cgit/liburing/commit/?id=f1af5ff51a3320a8971c611368c693c1dec560c5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From: mczka <58855170+mczka@users.noreply.github.com>
Use a real name and a real email address. No anonymous contribution.
io_uring-udp shown a bad source address in verbose mode - option '-v'.
Don't add a new commit to fix your previous unmerged commit. Just fold Also, as previously has been told, use a Signed-off-by with a real name |
I'll send a patch. |
bug #814
#814
git request-pull output:
Click to show/hide pull request guidelines
Pull Request Guidelines
notification, use
[GIT PULL]
as a prefix in your PR title.Commit message format rules:
Signed-off-by
tag with your real name and email. For example:The description should be word-wrapped at 72 chars. Some things should
not be word-wrapped. They may be some kind of quoted text - long
compiler error messages, oops reports, Link, etc. (things that have a
certain specific format).
Note that all of this goes in the commit message, not in the pull
request text. The pull request text should introduce what this pull
request does, and each commit message should explain the rationale for
why that particular change was made. The git tree is canonical source
of truth, not github.
Each patch should do one thing, and one thing only. If you find yourself
writing an explanation for why a patch is fixing multiple issues, that's
a good indication that the change should be split into separate patches.
If the commit is a fix for an issue, add a
Fixes
tag with the issueURL.
Don't use GitHub anonymous email like this as the commit author:
Use a real email address!
Commit message example:
By submitting this pull request, I acknowledge that: