Update to v2.4.165

.github/ISSUE_TEMPLATE/ask_question.md

@@ -1,16 +1,12 @@
 ---
-name: "Ask Question \U0001F4A1"
+name: Ask Question 💡
 about: Ask a Tartube related question
-title: ''
 labels: question
-assignees: ''
-
 ---
-
 Thanks for taking the time to ask a question! 
 
-### Please check the README
+### Please read the README
 Perhaps your question is answered there
 
 ### The authors are not experts in python, security, youtube-dl, FFmpeg, Debian/RPM packaging or Windows programming
-You are welcome to ask a Tartube-related question, but you might get a better answer in forums where those kinds of expert can be found
+You are welcome to ask a Tartube-related question, but you might get a better answer in forums where those kinds of expert can be found

.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,12 +1,10 @@
 ---
-name: "Bug report \U0001F41E"
+name: Bug report 🐞
 about: Create a report to help us improve
 title: ''
 labels: bug
 assignees: ''
-
 ---
-
 Thanks for taking the time to submit a bug report! Please include the following information:
 
 ### What operating system are you using?
@@ -15,5 +13,19 @@ If using MS Windows, are you using Windows 10, Windows 7, or something else?
 ### What version of Tartube are you using?
 In Tartube's main window, click Help > About
 
-### If your bug report is "I can't download this video", please provide a link to the video
-This will save a lot of time!
+### What happens when you run Tartube from a terminal window?
+Many error messages are only visible in the terminal window. On MS Windows, this is how to do it:
+
+- First, enable hidden folders on your system
+- Then, run the application: 
+
+    C:\Users\YOURNAME\AppData\Local\Tartube\msys64\mingw64.exe
+
+- In this new window, type these commands to start Tartube:
+
+    cd /home/user/tartube
+
+    python3 tartube/tartube
+
+###If your bug report is "I can't download this video", please provide a link to the video
+This will save a lot of time!

.github/ISSUE_TEMPLATE/feature_request.md

@@ -1,13 +1,13 @@
 ---
-name: "Feature Request \U0001F4A1"
+name: Feature Request 💡
 about: Suggest a new idea for the project.
-title: ''
 labels: enhancement
-assignees: ''
-
 ---
-
 Thanks for taking the time to submit a feature request! 
 
-### Please check the README
+### Make sure you are using the most recent version of Tartube
+Perhaps your feature request has already been implemented. The most recent version can be downloaded from Github
+
+### Please read the README
 Perhaps your feature request is already possible
+

CHANGES

@@ -1,3 +1,90 @@
+v2.4.165 (24 Nov 2022)
+-------------------------------------------------------------------------------
+
+MAJOR NEW FEATURES
+- Added a new tutorial. For new installations, it can be launched from the
+    setup window. For all users, it can be launched from Tartube's menu
+    (About > Show tutorial)
+- MS Windows users can now select a dark theme for Tartube windows. In
+    Tartube's menu, click 'System > Change theme...'. Advanced users may be
+    able to install additional themes; see the README for more details. Thanks
+    to Rukongai for finding the solution (Git #355)
+- Channels, playlists and folders can now have non-unique names; for example
+    you can have separate channels, both called 'Season 1', inside different
+    folders. However, you can't have two channels with the same name inside
+    the same folder (Git #439)
+- Download options can now be applied directly to more than one channel,
+    playlist or folder (Git #464)
+- Tartube has been re-licensed under LGPL 2.1
+
+MINOR NEW FEATURES
+- New translations available: French, Russian, Spanish and Vietnamese. Thanks
+    to everyone at Weblate who contributed to them, including Le Sharkoïste,
+    Tim Dewey, Equi and Zeref. In this release, your system's locale should be
+    applied automatically (no more messing around in the preferences window)
+- Python errors, which until now were hidden in a terminal window (and
+    therefore not visible to must users), are now redirected to Tartube's
+    Errors/Warnings tab where everyone can see them
+- In download options, Post-processing > General, the audio quality of the
+    post-processed audio file can now be set as a specific bitrate (e.g. 320
+    kb/s), as well as the 'high', 'medium' and 'low' settings that were already
+    available (Git #462)
+
+MAJOR FIXES
+- In the system preferences window, 'Downloaders' tab, tightened up the
+    behaviour of the buttons, entries and comboboxes so that the user cannot
+    specify contradictory settings or enter invalid values. On MS Windows, the
+    'Use custom path' setting is now marked as 'not recommended', because
+    Tartube code assumes that all users are using the official Tartube
+    installer. (It it apparently possible to install Tartube using WSL2, but
+    the authors have not been able to confirm that, so for the moment WSL2
+    installations are not 'officially' supported) (Git #466)
+- Fixed errors in the file-tidying operation (from Tartube's menu, Operations >
+    Tidy up files) (Git #423, #463)
+- .webp thumbnail images cannot be displayed in Tartube's window (because the
+    Gtk graphics libraries do not support them). By default, .webp thumbnails
+    are converted to .jpg (which are supported), but in some circumstances this
+    prevents users from embedding thumbnails into their videos. In this
+    version, when .webp thumbnails are converted to .jpg, the original .webp
+    files are not deleted (and so they are still available for embedding). You
+    can change this behaviour in Edit > System preferences... > Operations >
+    Downloads. You can use 'Operations > Tidy up files...' to remove multiple
+    .webp files at a later date, if you want to (Git #461)
+- Drag and drop into the 'Add new videos' window did not work as intended, if
+    videos were dropped directly onto the textview. Specifically, a newline
+    character was not inserted between existing and new URLs. This issue also
+    affected several similar windows, but is now fixed
+- When videos were downloaded as audio files (e.g. .m4a) and then converted to
+    another type of audio file (e.g. .mp3), Tartube's database was not updated
+    correctly. Due to some invisible magic in the operating system, most users
+    did not notice any problems, but some did. Fixed the issue, so that new
+    downloads will update the database correctly (Git #451)
+
+MINOR FIXES
+- In download options, Files > Filesystem, the 'Download all videos into this
+    folder' has been fixed so that it works correctly in non-English locales
+- Fixed drag-and-drop into the 'Media' tab of the 'Scheduled download' window
+- In the 'Add many channels/playlists' windows, names and URLs in the box at
+    the bottom were supposed to be editable, but were not. Fixed
+- Fixed a rare problem for videos that were marked to be watched as soon as
+    they are downloaded, in which it was possible (in principle) to delete the
+    video before the media player was launched, causing numerous problems
+- After fetching a list of video formats/subtitles, the dialogue window's
+    button opened the download options window at the wrong tab. Fixed
+- In the Drag and Drop tab, code did not impede the user's attempts to delete
+    the 'general' (default) set of download options (which cannot be deleted).
+    Fixed
+- Some youtube-dl commands surround download options with double quotes "...".
+    For technical reasons, these must be removed before Tartube can start a
+    youtube-dl download. Users were confused that the double quotes they had
+    specified were not visible in the Output tab; they are now visible there
+    (and also in the terminal window, when that is enabled) (Reddit)
+- The preferences window, when opened, will now auto-fix any problems with sets
+    of download options in the Tartube database. This is a temporary patch for
+    an unresolved issue. The authors suspect the unresolved issue has
+    resolved itself, given that code handling applied download options has been
+    completely re-written for this release (Git #456)
+
 v2.4.093 (31 Jul 2022)
 -------------------------------------------------------------------------------
 
@@ -11,7 +98,7 @@ MAJOR NEW FEATURES
     you should either select them, right-click and choose 'Download videos'; or
     alternatively, set up custom downloads to download each video individually
     (Git #445)
-    
+
 MINOR NEW FEATURES
 - In the preferences window, Operations > Livestreams, you can now block all
     livestreams from being checked/downloaded. This only works when yt-dlp is
@@ -24,15 +111,15 @@ MINOR NEW FEATURES
     now visible
 - Tartube translations can now be prepared using Weblate. See
     https://hosted.weblate.org/projects/tartube/ (Git #428)
-    
+
 MAJOR FIXES
 - Updated to latest version of MSYS2, with which FFmpeg can be installed
     correctly (Git #371, #444)
 
 MINOR FIXES
 - Fixed rare Python errors after right-clicking videos in the Progress List
     and selecting 'Stop now', 'Stop after this video', etc
-    
+
 v2.4.077 (8 Jun 2022)
 -------------------------------------------------------------------------------
 

README.rst

@@ -66,16 +66,16 @@ For a full list of new features and fixes, see `recent changes <CHANGES>`__.
 3 Downloads
 ===========
 
-Stable release: **v2.4.093 (31 Jul 2022)**
+Stable release: **v2.4.165 (24 Nov 2022)**
 
-Development release: **v2.4.149 (22 Nov 2022)**
+Development release: **v2.4.165 (24 Nov 2022)**
 
 Official packages (also available from the `Github release page <https://github.com/axcore/tartube/releases>`__):
 
-- `MS Windows (64-bit) installer <https://sourceforge.net/projects/tartube/files/v2.4.093/install-tartube-2.4.093-64bit.exe/download>`__ and `portable edition <https://sourceforge.net/projects/tartube/files/v2.4.093/tartube-2.4.093-64bit-portable.zip/download>`__ from Sourceforge
+- `MS Windows (64-bit) installer <https://sourceforge.net/projects/tartube/files/v2.4.165/install-tartube-2.4.165-64bit.exe/download>`__ and `portable edition <https://sourceforge.net/projects/tartube/files/v2.4.165/tartube-2.4.165-64bit-portable.zip/download>`__ from Sourceforge
 - Tartube is no longer supported on MS Windows (32-bit) - see `7.23 Doesn't work on 32-bit Windows`_
-- `DEB package (for Debian-based distros, e.g. Ubuntu, Linux Mint) <https://sourceforge.net/projects/tartube/files/v2.4.093/python3-tartube_2.4.093.deb/download>`__ from Sourceforge
-- `RPM package (for RHEL-based distros, e.g. Fedora) <https://sourceforge.net/projects/tartube/files/v2.4.093/tartube-2.4.093.rpm/download>`__ from Sourceforge
+- `DEB package (for Debian-based distros, e.g. Ubuntu, Linux Mint) <https://sourceforge.net/projects/tartube/files/v2.4.165/python3-tartube_2.4.165.deb/download>`__ from Sourceforge
+- `RPM package (for RHEL-based distros, e.g. Fedora) <https://sourceforge.net/projects/tartube/files/v2.4.165/tartube-2.4.165.rpm/download>`__ from Sourceforge
 
 Official 'Strict' packages:
 
@@ -92,7 +92,7 @@ Semi-official packages (Linux):
 
 Source code:
 
-- `Source code <https://sourceforge.net/projects/tartube/files/v2.4.093/tartube_v2.4.093.tar.gz/download>`__ from Sourceforge
+- `Source code <https://sourceforge.net/projects/tartube/files/v2.4.165/tartube_v2.4.165.tar.gz/download>`__ from Sourceforge
 - `Source code <https://github.com/axcore/tartube>`__ and `support <https://github.com/axcore/tartube/issues>`__ from GitHub
 - In case this Github repository is taken down, there is an official backup `here <https://gitlab.com/axcore/tartube>`__
 
@@ -548,6 +548,7 @@ The procedure used to create the MS Windows installer is described in full in th
 * `6.28.5 Video slice shortcuts`_
 * `6.29 Using youtube-dl forks`_
 * `6.30 Video comments`_
+* `6.31 Dark themes on MS Windows`_
 
 6.1 Setting up Tartube
 ----------------------
@@ -1950,6 +1951,47 @@ Alternatively, you can update the entire database at once. (This may take a long
 - Click **Edit > System preferences... > Files > Update**
 - Click the button **Extract comments for all videos**
 
+6.31 Dark themes on MS Windows
+------------------------------
+
+On Linux and MacOS, Tartube will automatically assume the desktop theme (whatever it is). That isn't technically possible on MS Windows, but if you want a darker window to match your darker desktop theme, do this:
+
+- Click **System > Change theme...**
+- In the new window's drop-down box, select **dark**, and click the **OK** button
+- Restart Tartube to apply the darker theme
+
+If you really want to, it's possible to add more themes to the small selection included in the MS Windows installer.
+
+First, select a suitable theme pack. Tartube's installer includes `this one <https://github.com/B00merang-Project/Windows-10-Dark>`__. Let's imagine a future installer that *doesn't* include that particular theme pack; this is how you would add it.
+
+- Locate Tartube's script folder. In Tartube's menu, click **System > Show Tartube script folder**
+- Navigate to the **\\pack\\mswin_themes** folder
+- Each of these folders specifies the name of a theme. Create a new folder called **dark**
+- Inside that folder, create a file called **settings.ini**
+- Open the file in a text editor, and add these lines:
+
+        [Settings] 
+
+        gtk-theme-name=Windows10
+
+Note that **Windows10** is the name of the theme pack, not the name of your operating system.
+
+- Re-start Tartube
+- Click **System > Change theme...**
+- Your **dark** should be visible in the drop-down box
+
+Now you must install the theme pack itself at the correct location.
+
+- Download the theme pack from the link above
+- Extract it, and navigate to the **gtk-3.20** folder. The files inside this folder are the ones you need to copy 
+- Next, in Tartube's menu, click **System > Show Tartube install folder**
+- In the new window, navigate to **msys64\\mingw64\\share\\themes**
+- Create a folder called **Windows10**, matching the theme pack's name
+- Inside that folder, create a folder called **gtk-3.0**
+- Copy the files from the theme pack's **gtk-3.20** folder into this new **gtk-3.0** folder
+
+You can now set the theme from Tartube's menu.
+
 7 Frequently-Asked Questions
 ============================
 
@@ -1986,8 +2028,10 @@ Alternatively, you can update the entire database at once. (This may take a long
 * `7.31 Tartube is not visible in the system tray`_
 * `7.32 Tartube is not portable`_
 * `7.33 Run out of disk space`_
-* `7.34 Japanese/Korean videos won't download`_
-* `7.35 No puedo hablar inglés`_
+* `7.34 Cannot embed thumbnails in videos`_
+* `7.35 Cannot install FFmpeg`_
+* `7.36 Japanese/Korean videos won't download`_
+* `7.37 No puedo hablar inglés`_
 
 7.1 Tartube won't install/won't run/doesn't work
 ------------------------------------------------
@@ -2463,7 +2507,25 @@ This seems to be an issue with the virtualisation software itself (we have confi
 
 The only thing that can be done is to disable the checks and warnings altogether. Click **Edit > System preferences > Files > Device**, and deselect both **Before checking/downloading videos, warn user if disk space is less than** and **Halt downloads if disk space is less than**.
 
-7.34 Japanese/Korean videos won't download
+7.34 Cannot embed thumbnails in videos
+--------------------------------------
+
+*Q: In download options, I enabled embedding thumbnails in my downloaded videos, but it doesn't work!*
+
+A: Make sure you have installed FFmpeg.
+
+A: Make sure you have not disabled the setting to remove .webp thumbnails after converting them to another format. Open **Edit > System preferences > Operations > Downloads**. If **Convert .webp thumbnails into .jpg thumbnails** is enabled, then **...but don't delete the original thumbnails** should also be enabled.
+
+7.35 Cannot install FFmpeg
+--------------------------
+
+*Q: I'm trying to install Tartube on MS Windows. When Tartube prompts me to install FFmpeg, the installation fails!**
+
+A: The software library that makes FFmpeg available for download breaks frequently. The only solution is to wait for the library to be fixed (but please still report the problem to Tartube's authors in the usual way).
+
+This issue only affects users on MS Windows.
+
+7.36 Japanese/Korean videos won't download
 ------------------------------------------
 
 *Q: On MS Windows, I can't download my favourite anime/K-pop video!*
@@ -2472,7 +2534,7 @@ A: This is an `unresolved bug <https://github.com/axcore/tartube/issues/320>`__
 
 As a workaround, click **Edit > General download options... > Files > Filesystem**, and then select **Restrict filenames to ASCII characters**. The videos should be downloaded and added to Tartube's database, but with garbled names (which is better than nothing.)
 
-7.35 No puedo hablar inglés
+7.37 No puedo hablar inglés
 ---------------------------
 
 *Q: ¡No puedo usar Tartube porque no hablo inglés!*

VERSION

@@ -1 +1 @@
-2.4.149
+2.4.165