Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No alarm sound when livestream starts #529

Closed
Lux-Hue opened this issue Mar 30, 2023 · 4 comments
Closed

No alarm sound when livestream starts #529

Lux-Hue opened this issue Mar 30, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@Lux-Hue
Copy link
Contributor

Lux-Hue commented Mar 30, 2023

linux fedora 37
tartube version 2.4.283

When a livestream is detected, and I turned on the "When a livestream starts, sound an alarm" checkbox, no audio is produced.
When testing with the "test" button manually, the following pops up in the log:

Error in sys.excepthook:
Traceback (most recent call last):
  File "/home/large/.local/bin/tartube", line 158, in handle_uncaught_exception
    raise type(value)
TypeError

Original exception was:
Traceback (most recent call last):
  File "/home/large/.local/lib/python3.11/site-packages/tartube/config.py", line 33802, in on_test_sound_clicked
    self.app_obj.play_sound()
  File "/home/large/.local/lib/python3.11/site-packages/tartube/mainapp.py", line 21581, in play_sound
    os.path.join(self.sound_dir, sound_name),
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen posixpath>", line 76, in join
TypeError: expected str, bytes or os.PathLike object, not NoneType
@Lux-Hue Lux-Hue added the bug Something isn't working label Mar 30, 2023
@axcore
Copy link
Owner

axcore commented Apr 7, 2023

Is the playsound module installed on your system? You can check by clicking Edit > System preferences > General > Modules

playsound

@Lux-Hue
Copy link
Contributor Author

Lux-Hue commented Apr 10, 2023

yeah, it does detect that it is installed
Screenshot_20230410_205128

@axcore
Copy link
Owner

axcore commented Apr 12, 2023

There is a typo in the installation file (setup.py) that moves sound files to the wrong location. Apparently you're the first person in three years to notice it.

This issue affects the DEB and RPM installers, but not the installer for MS Windows, not the PyPI installer, and does not affect Tartube when running directly from source code.

I have fixed the typo, and also added more checks to prevent the python error. The fix will be in the next release, which will be ready in a few days.

Workarounds:

  • [Fedora 37] Create the directory /usr/share/tartube/sounds. Move all of the .mp3 files from /usr/share/tartube/icons into /usr/share/tartube/sounds
  • [All Linux distros] Run Tartube directly from source code, as described here

axcore pushed a commit that referenced this issue Apr 12, 2023
@Lux-Hue
Copy link
Contributor Author

Lux-Hue commented Apr 12, 2023

Yep, the workaround fixed the issue, thanks!

@Lux-Hue Lux-Hue closed this as completed Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants