Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Sorting is not always triggered #611

Closed
tsk-2222 opened this issue Jan 2, 2024 · 4 comments
Closed

Video Sorting is not always triggered #611

tsk-2222 opened this issue Jan 2, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@tsk-2222
Copy link

tsk-2222 commented Jan 2, 2024

What operating system are you using? Windows 10

What version of Tartube are you using? v2.4.429

Reverse sort does not trigger properly.
To Reproduce:
When starting from a normal sort; Clicking reverse sort does nothing and clicking the 'resort videos' icon does nothing. You can then trigger the sorting function by right clicking on any video, click show video, click properties, click OK. At that point the sort function will be triggered to reverse sort the videos. BTW, leaving the folder and returning to the folder will also cause the sort order to be wrong.

When you are in reverse sort order then clicking the 'undo reverse sort' icon will work properly.

Additionally, non alphabet characters are being included in the sort. For instance the text "Watch This" will be sorted first when in alphabetical order.

@tsk-2222 tsk-2222 added the bug Something isn't working label Jan 2, 2024
@axcore
Copy link
Owner

axcore commented Jan 2, 2024

Reverse sort does not trigger properly

I have fixed his problem, but...

Additionally, non alphabet characters are being included in the sort.

I can't reproduce it; non-alphabetic characters should not affect the sort. Please give me the URL of a channel or playlist, which demonstrates this broken behaviour.

@tsk-2222
Copy link
Author

tsk-2222 commented Jan 2, 2024

Here's a video that starts with quotes:
https://www.youtube.com/watch?v=D090T2MSxKY
When sorted by name, the video title: "I Will Always Love You" Linda Ronstadt will be sorted before all other videos because the ascii for the quote character in the title comes before the ascii for any letter or number.

Perhaps the sort should be by uppercase letters and numbers only and exclude other characters.

@axcore
Copy link
Owner

axcore commented Jan 3, 2024

The reverse sort problem is fixed in v2.5.0. I haven't checked the other problem yet.

axcore pushed a commit that referenced this issue Jan 8, 2024
@axcore
Copy link
Owner

axcore commented Jan 8, 2024

Additionally, non alphabet characters are being included in the sort.

I fixed this in v2.5.003. The new code is uploaded only to github/pypi; Windows users can update their installation as described here.

@axcore axcore closed this as completed Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants