Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows/Linux path diffirence fixed #166

Merged
merged 3 commits into from
Apr 15, 2023
Merged

Windows/Linux path diffirence fixed #166

merged 3 commits into from
Apr 15, 2023

Conversation

saracalihan
Copy link
Member

@saracalihan saracalihan commented Apr 15, 2023

Description

We can use the / character in the URL, Path.join function is join word with / on *nix but on Windows, it uses \ character for os behavior.

Close #164

Motivation and Context

I hard-coded it.

How has this been tested?

Tested on Windows 11 and Linux5 manually.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@saracalihan saracalihan linked an issue Apr 15, 2023 that may be closed by this pull request
@ozziest ozziest self-assigned this Apr 15, 2023
@ozziest
Copy link
Member

ozziest commented Apr 15, 2023

@saracalihan can you remove the unused path definition? That's why you are getting code smells from SonarCloud.

image

Copy link
Member

@ozziest ozziest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great. 👏 👏 We just need a tiny change in the changelog.

CHANGELOG.md Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Apr 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ozziest ozziest added bug Something isn't working version-patch It is just a patch for the current version. It is not a new feature, nor a breaking change. labels Apr 15, 2023
@ozziest ozziest merged commit bd8d5a8 into master Apr 15, 2023
@saracalihan saracalihan deleted the bug-164 branch April 15, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working version-patch It is just a patch for the current version. It is not a new feature, nor a breaking change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

windows version routes not working
2 participants