Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #149 #234

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Fixed #149 #234

merged 1 commit into from
Jul 4, 2023

Conversation

ozziest
Copy link
Member

@ozziest ozziest commented Jul 4, 2023 •
edited
Loading

Description

Added prettier pre-hooks and Eslint checks.

Motivation and Context

#149

How has this been tested?

Added ESLint to the GitHub actions.

Types of changes

  • Internal

@ozziest ozziest changed the title Lint Fixed #149 Jul 4, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

@ozziest ozziest marked this pull request as ready for review July 4, 2023 16:02
Arifkarakilic
Arifkarakilic approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@Arifkarakilic Arifkarakilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job🎉

@ozziest ozziest merged commit d3261af into develop Jul 4, 2023
28 checks passed
@ozziest ozziest deleted the lint branch July 5, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arifkarakilic Arifkarakilic Arifkarakilic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ozziest @Arifkarakilic