style(code): implements eslint & prettier #31
Conversation
| @@ -1,175 +1,1770 @@ | |||
| { | |||
There was a problem hiding this comment.
We should ignore this since this files is managed by npm, not by hand
There was a problem hiding this comment.
Pretty sure I did touch it via npm only, no prettier or eslint included. Will regenerate it to ensure this :)
There was a problem hiding this comment.
Alright, no changes did show up after deleting the file and reinstalling. Should be fine as it is :)
src/index.js
Outdated
| const sizeOf = require('image-size') | ||
| const argv = require('argv') | ||
| const os = require('os') | ||
| const childProcess = require('childProcess') |
There was a problem hiding this comment.
Package name is child_process so this is going to brake,
There was a problem hiding this comment.
😱 omg yes, sorry for this one 😅
BREAKING CHANGE: lib return values are now camelCased
axe312ger
force-pushed
the
style/eslint-prettier
branch
from
9926c9f
to
dedb8af
Compare
src/index.js
Outdated
| const sizeOf = require('image-size') | ||
| const argv = require('argv') | ||
| const os = require('os') | ||
| const childProcess = require('child-process') |
There was a problem hiding this comment.
I think it is still wrong ? 😄
There was a problem hiding this comment.
Also eslint will fail on camelcase I assume, for that we can disable check for that line.
There was a problem hiding this comment.
I am not sure what u mean here. Camelcase is enforced for variable names, not for module names/string content 🤔
There was a problem hiding this comment.
Looks like it is not failing on ESLint as you said sorry :)
But child_process module is with underscore instead of dash.
There was a problem hiding this comment.
Omg. Sure! Note to myself: Test the code before pushing.
Usually I do that but since we plan do do more for the next version I actually did not test this commit. Sorry
|
@efegurkan fixed 😅 |
|
@axe312ger LGTM, feel free to merge it :) |
BREAKING CHANGE: lib return values are now camelCased
BREAKING CHANGE: lib return values are now camelCased
BREAKING CHANGE: lib return values are now camelCased
BREAKING CHANGE: lib return values are now camelCased
This is my first step to get this lib in 2018 shape. 99% of the changes are auto fixed from eslint or prettier. I'd keep this in the next branch and start releasing 1.0.0-alpha's as soon we got the plugin system running.
Next step might be upgrading all dependencies.