Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add socks5 support #2

Open
sijad opened this issue Mar 18, 2016 · 7 comments
Open

Add socks5 support #2

sijad opened this issue Mar 18, 2016 · 7 comments
Labels
enhancement help wanted
Milestone
v3.0

Comments

@sijad
Copy link
Contributor

sijad commented Mar 18, 2016

This is wonderful to see updated Axel, currently when I wan use socks5 as proxy for example I get this error:

Invalid proxy string: socks5://127.0.0.1:1080

I'm not a very good programmer but I'd love to spend time on this, let me know if you think this is a good idea
@eribertomota
Copy link
Collaborator

Hi sijad,

Feel free to help Axel. Initialy, send me a patch and I will add you to the project, if you want it.

Regards,

Eriberto

@sijad
Copy link
Contributor Author

sijad commented Mar 18, 2016

should I work on broken v3?

@sijad
Copy link
Contributor Author

sijad commented Mar 18, 2016

as v3 is 80 commit behind I think continuing v2 is better right now

@eribertomota
Copy link
Collaborator

Today, I am doing several commits. Please, take advantage of this.

@eribertomota eribertomota mentioned this issue May 30, 2016
Closed
12 tasks
@BrainMaestro BrainMaestro mentioned this issue Jul 31, 2017
Closed
@ismaell ismaell added this to the v3.0 milestone Aug 25, 2017
@sijad
Copy link
Contributor Author

sijad commented Dec 10, 2017

is it a good idea to use a library like https://github.com/darkk/redsocks?

@ordex
Copy link
Member

ordex commented Dec 10, 2017

I think it would be much better to avoid adding other dependencies unless strictly required. Don't you think it is possible to implement basic socks support without a library?

@sijad
Copy link
Contributor Author

sijad commented Dec 10, 2017

I'm not sure, I can tell you after reading http://www.rfc-editor.org/rfc/rfc1928.txt

@RichardRo RichardRo mentioned this issue Apr 6, 2019
Closed
ismaell pushed a commit that referenced this issue May 10, 2019
@foutrelis @ismaell
Fix comparison error in axel_divide
381459c 
The comparison of maxconns and num_connections was inverted, resulting
in a buffer overflow.

Debugging Session:
	gdb --args ./src/axel https://speed.hetzner.de/100MB.bin
	[...]
	Initializing download: https://speed.hetzner.de/100MB.bin
	File size: 104857600 bytes

	Program received signal SIGSEGV, Segmentation fault.
	0x000055555555a81a in axel_divide (axel=0x55555556b410) at axel.c:853
	853                     axel->conn[i].currentbyte = seg_len * i;
	(gdb) p i
	$1 = 87
	(gdb) p axel->conf->num_connections
	$2 = 1024
	(gdb) bt
	#0  0x000055555555a81a in axel_divide (axel=0x55555556b410) at
	axel.c:853
	#1  0x00005555555586e4 in axel_open (axel=0x55555556b410) at axel.c:317
	#2  0x0000555555561bb4 in main (argc=2, argv=0x7fffffffe778) at
	text.c:379

Fixes: 5aac471
	("Fix request range calculation")
Fixes: #205

[ismael: Added commit message]
Signed-off-by: Ismael Luceno <ismael@iodev.co.uk>
@creynaud creynaud mentioned this issue May 13, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
v3.0
Development

No branches or pull requests
4 participants
@ismaell @ordex @eribertomota @sijad