feat: switch to hardhat toolbox #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
milapsheth
commented
Apr 11, 2023
•
milapsheth
commented
- Switch to hardhat toolbox
- Fix GMP tests to use hardhat
- Remove waffle dependency
- Update deps to recent versions
milapsheth
commented
Apr 11, 2023
| .to.not.emit(gateway, 'TokenDeployed') | ||
| .and.to.emit(gateway, 'Executed') | ||
| .withArgs(secondCommandID); | ||
| await expect(gateway.execute(secondInput)).to.not.emit(gateway, 'Executed').to.emit(gateway, 'TokenDeployed'); // TODO: fix |
There was a problem hiding this comment.
Found a bug with our chai usage, this should actually fail because the event shouldn't be emitted. Can't figure out the right usage here. .and doesn't do anything, need a way to combine multiple tests.
re1ro
approved these changes
Apr 12, 2023
re1ro
added a commit
that referenced
this pull request
Apr 12, 2023
* Migrated all but gmp test to hardhat * Fixed lint errors * GMP test error for debugging * updated ethers imports * test(DepositService): import hardhat config * feat: switch to hardhat toolbox (#185) * fix: switch to hardhat toolbox * chore: update deps * revert prettier version * pin prettier solidity plugin * addressed test comment --------- Co-authored-by: Dean Amiel <damiel@deans-mbp.lan> Co-authored-by: Kiryl Yermakou <rma4ok@gmail.com> Co-authored-by: Milap Sheth <milap@axelar.network>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.