Gateway: token deployer storage + upgrade #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fish-sammy
requested changes
Apr 14, 2022
| @@ -12,9 +12,17 @@ contract AxelarGatewayProxy is EternalStorage { | |||
| /// @dev Storage slot with the address of the current factory. `keccak256('eip1967.proxy.implementation') - 1`. | |||
| bytes32 internal constant KEY_IMPLEMENTATION = | |||
| bytes32(0x360894a13ba1a3210667c828492db98dca3e2076cc3735a920a3ca505d382bbc); | |||
|
|
|||
| constructor(address gatewayImplementation, bytes memory params) { | |||
| /// @dev Storage slot with the address of the current token deployer. `bytes32(uint256(keccak256('eip1967.proxy.token.deployer')) - 1)` | |||
There was a problem hiding this comment.
I don't like the idea of having proxy knowing how implementation is done. Specifically here, we are making the proxy aware that there's such a thing as token deployer which is what the implementation cares about. The proxy should only deal with implementation instead of getting involved into this kind of implementation details.
|
Closing due the contract size bloat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
immutable TOKEN_DEPLOYER_IMPLEMENTATIONKEY_TOKEN_DEPLOYER_IMPLEMENTATIONstorage slotupgradeTokenDeployermethodAxelarGatewayMultisigcontract code size exceeds 24576 bytes