fix(axelarnet): remove unused TxID parameter from ConfirmDepositRequest #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack0son
requested review from
cgorenflo,
jcs47 and
fish-sammy
as code owners
jcs47
reviewed
Jan 16, 2022
x/axelarnet/client/cli/tx.go
Outdated
| burnerAddr, err := sdk.AccAddressFromBech32(args[2]) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| msg := types.NewConfirmDepositRequest(cliCtx.GetFromAddress(), txID, args[1], burnerAddr) | ||
| msg := types.NewConfirmDepositRequest(cliCtx.GetFromAddress(), nil, args[1], burnerAddr) |
There was a problem hiding this comment.
update the contructor so not to ask for this parameter, but do not remove the field from the protobuf
There was a problem hiding this comment.
also, i almost forgot: mark the field as deprecated on the protobuf like this: https://github.com/axelarnetwork/axelar-core/blob/main/proto/axelarnet/v1beta1/tx.proto#L32
jack0son
force-pushed
the
fix/axelarnet-confirm-deposit-txid
branch
from
774a6be
to
931a560
Compare
jcs47
approved these changes
Jan 16, 2022
haiyizxx
approved these changes
Jan 17, 2022
fish-sammy
reviewed
Jan 17, 2022
proto/axelarnet/v1beta1/tx.proto
Outdated
Comment on lines
31
to
34
| bytes tx_id = 2 [ | ||
| (gogoproto.customname) = "TxID", | ||
| deprecated = true | ||
| ]; |
There was a problem hiding this comment.
Suggested change
| bytes tx_id = 2 [ | |
| (gogoproto.customname) = "TxID", | |
| deprecated = true | |
| ]; | |
| reserved 2; // tx_id was removed in v0.14 |
There was a problem hiding this comment.
I suggest just removing it and reserving the field number for backward compatibility.
There was a problem hiding this comment.
Should "tx_id" also be reserved?
There was a problem hiding this comment.
Have reserved 2 at this stage
fish-sammy
approved these changes
Jan 25, 2022
fix remove txID from constructor and update rest endpoint deprecate the txID field remove txID from ConfirmDeposit message and reserve its proto index
jack0son
force-pushed
the
fix/axelarnet-confirm-deposit-txid
branch
from
474bcfc
to
b112e66
Compare
jcs47
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TxID is not necessary because ConfirmDeposit confirms the full available balance rather than a specific transaction.
This PR removes the TxID parameter from the CLI command and the request message validation.
Todos
Steps to Test
Expected Behaviour
Other Notes